From owner-svn-src-head@FreeBSD.ORG Sun Nov 30 19:03:16 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E1F743F5; Sun, 30 Nov 2014 19:03:16 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6044F74E; Sun, 30 Nov 2014 19:03:15 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sAUJ3DRs027964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 30 Nov 2014 22:03:13 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sAUJ3DlN027963; Sun, 30 Nov 2014 22:03:13 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Sun, 30 Nov 2014 22:03:13 +0300 From: Gleb Smirnoff To: Adrian Chadd Subject: Re: svn commit: r275326 - in head: sys/dev/cxgbe/tom sys/kern sys/netinet sys/sys usr.bin/bluetooth/btsockstat usr.bin/netstat usr.bin/systat Message-ID: <20141130190313.GC47144@FreeBSD.org> References: <201411301252.sAUCqYXm055601@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Nov 2014 19:03:17 -0000 Adrian, On Sun, Nov 30, 2014 at 09:55:05AM -0800, Adrian Chadd wrote: A> The whole idea of an mbuf whose data isn't quite there yet makes A> debugging issues rather amusing, as now you may have VM issues to A> debug at the same time as you're debugging network related stuff. I don't see how VM issues are related. The mbufs are referencing allocated, mapped and wired pages via sf_bufs. The same way as they did it since 1998. The only difference is that pages aren't populated with data. No VM changes happen to the pages while the mbufs that reference them sit in the socket buffer. A> I really think this could've been done without all the back-handed VM A> work. The mbufs and IO buffers both have completion function calls; it A> would've been much less intrusive to do it that way. If you can describe the alternative design at least in some detail, I am listening. -- Totus tuus, Glebius.