From owner-svn-src-all@freebsd.org Thu Mar 30 08:36:42 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D12CCD23638; Thu, 30 Mar 2017 08:36:42 +0000 (UTC) (envelope-from royger@gmail.com) Received: from mail-vk0-x22e.google.com (mail-vk0-x22e.google.com [IPv6:2607:f8b0:400c:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 847CD9C4; Thu, 30 Mar 2017 08:36:42 +0000 (UTC) (envelope-from royger@gmail.com) Received: by mail-vk0-x22e.google.com with SMTP id d188so45829627vka.0; Thu, 30 Mar 2017 01:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=L2w4Z05tqqIRgPGvv2T8QItAm+IoxL+YQp09Xea2C38=; b=qESQ6nLj9lpLngMPGxejLqgm95Y91e1SmTXpUhQY/3HGz6j9dw4lMcvhOQ8oEO52Zp 8hdJyfigmw+Z/FddasO/meSs8PiNClNy2XUekQ0CdjorDv03D0ZTmn5yx4KHHQ0tsu1O xJOIiM4/PjZzCXg21JgGlQ+F1t+6AUrlB8dtgQEU5PktVA0epdiFlrVnn51/IE6rMTpL USbFnCbSxn5NwNMZiGbSbSXiTDgaiT/uQPg9dlxASUGsNfDYSIsLpKztg8ehN97BEluF d1fxY3oXQryGbBqbMYXZD4R5eGS2UaTnVxKnYHqezdz/xK0AdOKPQFf1V+5x7o7RkL15 7WSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=L2w4Z05tqqIRgPGvv2T8QItAm+IoxL+YQp09Xea2C38=; b=Y+jxMwIF4NUwOC9XcYqUfXV0NLYthZmQaGtExXOpI9SxD9Zou7bNgakqem7KRa/131 Lr6uzugd+hXL17MmcDxmfdSfT+2kruYshiBNacyIHqlgO4ovMT9pP2Lco5vxw/8L37zj 9R47lUK9vlLgcRn8LrBtSXOSggZSapncJb8cJSyFrh8OjiOLbYnabW5Iq6vhNHINdb0R lZSoiKeCjE5kJiaWTwer+51INMS9rI4OIrNFYtfz+KQ+vnCxtdvCj6hIGxGq32Q8TF8W Jb0yzgoFn6pXLVgnXlXzqvayTiEvUKfT9A3RvkcqUbNWvWEQTmPMcs/fIK+V8waLwnV0 cS9Q== X-Gm-Message-State: AFeK/H39zEpDPHHaVUMoUBrjzoDzfopgpjW0m8V1WzTydQYgSsmIfMs3kZlJIzPJtxnzuw== X-Received: by 10.31.237.2 with SMTP id l2mr2560743vkh.8.1490863001444; Thu, 30 Mar 2017 01:36:41 -0700 (PDT) Received: from localhost (default-46-102-197-194.interdsl.co.uk. [46.102.197.194]) by smtp.gmail.com with ESMTPSA id i55sm402444uaa.26.2017.03.30.01.36.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2017 01:36:40 -0700 (PDT) Sender: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Date: Thu, 30 Mar 2017 09:36:31 +0100 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: "Ngie Cooper (yaneurabeya)" Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r316140 - stable/10/sys/dev/xen/netfront Message-ID: <20170330083631.dtututkocx3t24pb@dhcp-3-128.uk.xensource.com> References: <201703291534.v2TFYq2j041847@repo.freebsd.org> <4E2E5DD5-58CB-4847-8E7A-CCF6734E8904@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4E2E5DD5-58CB-4847-8E7A-CCF6734E8904@gmail.com> User-Agent: NeoMutt/20170306 (1.8.0) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 08:36:42 -0000 On Wed, Mar 29, 2017 at 10:12:23AM -0700, Ngie Cooper (yaneurabeya) wrote: > > > On Mar 29, 2017, at 08:34, Roger Pau Monné wrote: > > > > Author: royger > > Date: Wed Mar 29 15:34:52 2017 > > New Revision: 316140 > > URL: https://svnweb.freebsd.org/changeset/base/316140 > > > > Log: > > xen/netfront: release resources on removal > > > > Current netfront code doesn't release the resources (grants and mbufs) on > > removal. Add a new helper that releases the resources, so FreeBSD doesn't run > > out of grants or memory when performing heavy hotplug/unplug of Xen PV nic > > devices. > > > > This is a direct commit to stable/10 because the code in newer branches has > > been completely refactored and no longer has this issue. > > > > Reviewed by: royger > > Submitted by: Ouyangzhaowei > > Differential review: https://reviews.freebsd.org/D10088 > > Hi Roger, > This broke GENERIC/i386 with a -Wformat warning, but was fixed in r316170. Sight. It was supposedly "thoroughly tested". Sorry for the breakage and thanks for the fix! Roger.