From owner-p4-projects@FreeBSD.ORG  Sun Jul  6 02:10:15 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id CAF7D1065676; Sun,  6 Jul 2008 02:10:15 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8C9EC1065671;
	Sun,  6 Jul 2008 02:10:15 +0000 (UTC)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp
	[133.80.152.80])
	by mx1.freebsd.org (Postfix) with ESMTP id 252BF8FC0A;
	Sun,  6 Jul 2008 02:10:14 +0000 (UTC)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from localhost (localhost [IPv6:::1])
	by watery.cc.kogakuin.ac.jp (unknown) with ESMTP id m662AE4t075191;
	Sun, 6 Jul 2008 11:10:14 +0900 (JST)
	(envelope-from nyan@jp.FreeBSD.org)
Date: Sun, 06 Jul 2008 11:09:43 +0900 (JST)
Message-Id: <20080706.110943.226722229.nyan@jp.FreeBSD.org>
To: marcel@freebsd.org
From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
In-Reply-To: <200807051943.m65JhHZ6066371@repoman.freebsd.org>
References: <200807051943.m65JhHZ6066371@repoman.freebsd.org>
X-Mailer: Mew version 6.1 on Emacs 22.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 144741 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jul 2008 02:10:16 -0000

In article <200807051943.m65JhHZ6066371@repoman.freebsd.org>
Marcel Moolenaar <marcel@freebsd.org> writes:

>  static struct isa_pnp_id isa_i8251_ids[] = {
>  	{0x0100e4a5, "RSA-98III"},
>  	{0}
>  };

>  	/* Probe PnP _and_ non-PnP i8251 here. */
>  	if (ISA_PNP_PROBE(parent, dev, isa_i8251_ids) != ENXIO) {
>  		sc->sc_class = &uart_i8251_class;
>  		return (uart_bus_probe(dev, 0, 0, 0, 0));
>  	}

These are wrong.  RSA98-III is based on ns8250 and has extended FIFO
buffer.  So I think that the uart_rsa_class should be added.

FYI, RSA series are not for pc98 only.
RSA-PCI (PCI) and RSA-DVII (ISA) exist but not supported yet.

---
TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>