From owner-svn-src-head@FreeBSD.ORG Tue Jul 8 07:09:16 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8FBA9818; Tue, 8 Jul 2014 07:09:16 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6457422E9; Tue, 8 Jul 2014 07:09:15 +0000 (UTC) Received: from Julian-MBP3.local (ppp121-45-236-203.lns20.per1.internode.on.net [121.45.236.203]) (authenticated bits=0) by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id s6879Bke049432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 8 Jul 2014 00:09:13 -0700 (PDT) (envelope-from julian@freebsd.org) Message-ID: <53BB9911.60804@freebsd.org> Date: Tue, 08 Jul 2014 15:09:05 +0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Warner Losh , svn-src-head@freebsd.org Subject: Re: svn commit: r268376 - head/bin/rm References: <201407072321.s67NLL7p070713@svn.freebsd.org> In-Reply-To: <201407072321.s67NLL7p070713@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jul 2014 07:09:16 -0000 On 7/8/14, 7:21 AM, Warner Losh wrote: > Author: imp > Date: Mon Jul 7 23:21:20 2014 > New Revision: 268376 > URL: http://svnweb.freebsd.org/changeset/base/268376 > > Log: > rm -rf can fail sometimes with an error from fts_read. Make it honor > fflag to ignore fts_read errors, but stop deleting from that directory > because no further progress can be made. > > When building a kernel with a high -j value on a high core count > machine, during the cleanobj phase we can wind up doing multiple rm > -rf at the same time for modules that have subdirectories. This > exposed this race (sometimes) as fts_read can return an error if the > directory is removed by another rm -rf. Since the intent of the -f > flag was to ignore errors, even if this was a bug in fts_read, we > should ignore the error like we've been instructed to do. One could make an argument that being unable to delete something because someone else deleted it first is a "non error". Even without -f >