From nobody Thu Feb 2 11:14:35 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4P6x574x5Sz3cwfW; Thu, 2 Feb 2023 11:14:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4P6x574M2fz46nf; Thu, 2 Feb 2023 11:14:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675336475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wTyPO6reHsZikVmZC0UqmpcJi1JyRxW5VDuR4i11NT4=; b=S2gBWxPDwHwHOsIoP/evkljhXfJ6dW3YIVjGCmgvE3N968+c+w43DIWSYFqN+ZXIRwQcGt yNMVjxc6GHZREu757/EQZBqCRQ0NchKvGM6WV4sr2o+tMWJe5rDIqn+qT9eO0h3z4VF3Yu PSEX23sJ2bvBOcMv7m78pV0+txmpVmXPzyojaHCUPZiRgL/IAoB9TWyQizhesNN881aX2I kWOEz79+escTr7aUKGkAGmMg+fjQnH7+6wJtFwopLO46uZXc+qQ0LlDhcIx9uRxoWA2WsO Spphj4QxThjkeSnb2sUlz67nfYTh9Om07BHVh7owmwKwrgCWlPGRbEG5PHftsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1675336475; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wTyPO6reHsZikVmZC0UqmpcJi1JyRxW5VDuR4i11NT4=; b=kDeL4TYKcGuVW8XbS180hPx/WcO1XEyrpkN+Gvlo0u+ZGovhNSy2CmWmp/BYLoBuJdqnzS 4GziJGDo0rqaYkXuJob3glKzsGR4x07+jJJ6JJqWzXq0MSgLDgG/aj28v691ylJHzB7BK8 biQ5lflpTbVEcVYcAMLuDfLcbbt75+0QEZstROjLxgq338hbNrIhrxD/2nIrQrIa9rceJt 7kDiCs9VDgxHSuX6hF6FA2h9MYbvGl+G3gNGDN8nPXwBuNED03DddezdNF8BBswXU3AJQq kX8iOj6aDhaV8PTyjHXoX7BmlVrAaZwTJJj4s5TcmXJF9KFtAe4w4OboBQDkew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1675336475; a=rsa-sha256; cv=none; b=yP0MXitFnAbhkACsJGwWS6WW/pSPXPwXJo2KQbOijDnTRmO2nB3II8S6ktY00Ip4HFdq9h pdvssjTRn8DG7AhKLOPseTMVsz16V42YVQs7O8zE02dLSQDu7nSg8Cs/6PlS4RjLW+pRJn 8mC/xwT/PlI7rdJSRtLFQI35jNWk7EafF/Ld1gGBWNdpmwnUy3NlMzG2RkuP34xvFbWg1J 9Cr0VzLnbw6Z0FPcclLZTiGnfPQba0YG0z87bEssoqGbBRfFXjO6aXX6nm3QORzVv7V0n7 dMHfONyFuwycl+/YIOgEzwu6tRmHiVEYqNujiOk2oxJFrFm/wqbBJykIXa3nUA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4P6x573KMXzsLB; Thu, 2 Feb 2023 11:14:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 312BEZbm076682; Thu, 2 Feb 2023 11:14:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 312BEZVe076681; Thu, 2 Feb 2023 11:14:35 GMT (envelope-from git) Date: Thu, 2 Feb 2023 11:14:35 GMT Message-Id: <202302021114.312BEZVe076681@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Emmanuel Vadot Subject: git: 19956b44dcfd - stable/13 - linuxkpi: seq_read: Fix off by one error List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 19956b44dcfd6aadc096cd167e975f02a3804964 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=19956b44dcfd6aadc096cd167e975f02a3804964 commit 19956b44dcfd6aadc096cd167e975f02a3804964 Author: Emmanuel Vadot AuthorDate: 2022-12-21 11:42:24 +0000 Commit: Emmanuel Vadot CommitDate: 2023-02-02 11:10:37 +0000 linuxkpi: seq_read: Fix off by one error strscpy needs the buffer length not the string length (so including the '\0'). Reviewed by: bz Fixes: f697b9432d9c ("linuxkpi: drm-kmod debugfs support") Sponsored by: Beckhoff Automation GmbH & Co. KG Differential Revision: https://reviews.freebsd.org/D37771 (cherry picked from commit ccd8c4488afb15c2b866b58d5aa9dd994f300f95) --- sys/compat/linuxkpi/common/src/linux_seq_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_seq_file.c b/sys/compat/linuxkpi/common/src/linux_seq_file.c index c358e4ae7dc1..d4d8ef059ac4 100644 --- a/sys/compat/linuxkpi/common/src/linux_seq_file.c +++ b/sys/compat/linuxkpi/common/src/linux_seq_file.c @@ -67,7 +67,7 @@ seq_read(struct linux_file *f, char *ubuf, size_t size, off_t *ppos) return (-EINVAL); size = min(rc - *ppos, size); - rc = strscpy(ubuf, sbuf_data(sbuf) + *ppos, size); + rc = strscpy(ubuf, sbuf_data(sbuf) + *ppos, size + 1); /* add 1 for null terminator */ if (rc > 0)