From owner-svn-src-all@freebsd.org Fri Nov 3 22:28:36 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B99DE5CA63; Fri, 3 Nov 2017 22:28:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D0AE760D9; Fri, 3 Nov 2017 22:28:36 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 9FA5233BA; Fri, 3 Nov 2017 22:28:35 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 89D9D2E02; Fri, 3 Nov 2017 22:28:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id i5Y-F1YL72fW; Fri, 3 Nov 2017 22:28:26 +0000 (UTC) Subject: Re: svn commit: r325116 - head DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 87E852DFD To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201710300312.v9U3CcCT021416@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> Date: Fri, 3 Nov 2017 15:28:25 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201710300312.v9U3CcCT021416@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 22:28:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9 Content-Type: multipart/mixed; boundary="SpU4G7rf55SnwvJPEs3FlO9GkhgR0f2an"; protected-headers="v1" From: Bryan Drewery To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <8d9e9f50-035c-403c-3bc5-6788b7a94dea@FreeBSD.org> Subject: Re: svn commit: r325116 - head References: <201710300312.v9U3CcCT021416@repo.freebsd.org> In-Reply-To: <201710300312.v9U3CcCT021416@repo.freebsd.org> --SpU4G7rf55SnwvJPEs3FlO9GkhgR0f2an Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/29/2017 8:12 PM, Warner Losh wrote: > Author: imp > Date: Mon Oct 30 03:12:38 2017 > New Revision: 325116 > URL: https://svnweb.freebsd.org/changeset/base/325116 >=20 > Log: > Return proper status from buildenv. > =20 > make buildenv BUILDENV_SHELL=3D more useful. Remove '||= > true' from the command line so that errors are properly > returned. There appears to be no reason for it, and it dates back to > the original commit by ru@. > =20 > Sponsored by: Netflix Now simply running 'make buildenv' and 'exit' throws a make error. Perhaps we need a BUILDENV_CMDS that does what you want and we otherwise leave the ${BUILDENV_SHELL} || true handling. >=20 > Modified: > head/Makefile.inc1 >=20 > Modified: head/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/Makefile.inc1 Mon Oct 30 03:12:34 2017 (r325115) > +++ head/Makefile.inc1 Mon Oct 30 03:12:38 2017 (r325116) > @@ -991,8 +991,7 @@ buildenv: .PHONY > .if ${BUILDENV_SHELL:M*zsh*} > @echo For ZSH you must run: export CPUTYPE=3D${TARGET_CPUTYPE} > .endif > - @cd ${BUILDENV_DIR} && env ${WMAKEENV} BUILDENV=3D1 ${BUILDENV_SHELL}= \ > - || true > + @cd ${BUILDENV_DIR} && env ${WMAKEENV} BUILDENV=3D1 ${BUILDENV_SHELL}= > =20 > TOOLCHAIN_TGTS=3D ${WMAKE_TGTS:Neverything:Nbuild${libcompat}} > toolchain: ${TOOLCHAIN_TGTS} .PHONY >=20 --=20 Regards, Bryan Drewery --SpU4G7rf55SnwvJPEs3FlO9GkhgR0f2an-- --pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/O2KAAoJEDXXcbtuRpfPp44H/0gqCh0jaPTYRDX0b+wLXEWK +Jk3y2GaUIaYGr9TyJPdkzj4aVdIhOet6GCFxPVEuvM/tGUtSz0bFblZ5yZGvEUr rkv+ivTfio/uSIRVgQPDjZ//3wWbY98XzWnVFWfkHccbFpB/+/+LMSpzdWhcyrsF 3mcRlIJsFZT9gd0lcHFiughNin40VmK4/YOnP5jtOsJA42Hm1ILwywPTHbHhrXzW 1UgGAK24U94qvBTSCkgUmOp3Ke2u3FuEnfFQL6xFFOHyIwXddu/BgOgdU7/w/GCd vxjW4+Q13CpLO9VxpNnjOwBfRtIsS4NLgRGb5S2lSG787ARHjhJXTCqD8pXP7KE= =sq8y -----END PGP SIGNATURE----- --pgPP7DPs5xF97Lq8QmsdmDWa12bhLKJJ9--