From owner-freebsd-hackers@freebsd.org Thu Aug 29 15:09:02 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D22BED8B11; Thu, 29 Aug 2019 15:09:02 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46K5by52Vkz3JfT; Thu, 29 Aug 2019 15:09:02 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lj1-x243.google.com with SMTP id l14so3415718lje.2; Thu, 29 Aug 2019 08:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=q+v6xLmI+5EfAk0WfFddMXmOZ8cUNN7J5HBg/AFEXdc=; b=ICOsuU4Mgn6hQRvyzUxmu9xnbFJxGaVLjg5kh8Z21ZZo0XB4j84kQ9++iJw0jk96Ai zRri8oVYQIC1/6ZSxuo9kPD4MP2cMiRnzFgUfX69K6DD4Cs7syrO8Wy9MmUfRd+WJS6v GjYqcr18ut+ZuH3/rjzOkbjhko/9ahkCkSNfaGq7WveSYmZtnVL7ZkzpsL+wvVAA5GZq Uu6agEWtSJzHFB74imQVwCiw1VCJ+UoNzJZRmr+1f6YM9VeDSBRYItKI7yeHmZ2H391m +m3Vb2siWiKMX/QvcwXugKFzfLtgg13vJZeBRby/PtF+BnqFZjiuz/sBMyl6tZnb8SCW ByWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=q+v6xLmI+5EfAk0WfFddMXmOZ8cUNN7J5HBg/AFEXdc=; b=GiNXpbB99NJ1BN2gafP7uTL0TLl8B+4BplopGJ1ioVb7Ga9V7/BT4YzNdGInG4iqv3 AmTbE9QJd2CpJYDvRcpzzhLuW5i1aaZP33uZAZFSKU+47Pqy4fjQ2tuwexQomQg5t9iw tykL6mmX5tJ4gU75jn50O/aY1najx2/kqXBgRbyGMvzOhcOHLvqW5JjW4prxdin6Z/EN 6QxFXs6KDX/kBsJlZYUnFOISPm5+kDNG/ufXQ2kjuFhx+2HRkDlfUn84X/PPfLbAS62X q341RREFG351sr3k3FtwMWtps4B6BDgeTyCeLmQWHrVKL+Hu+9SXcwx1+hEabzRV1Gio dLew== X-Gm-Message-State: APjAAAX+U/RbhZ7hQHNJcnLm8D6z3gmllS0OScwHPDn5rK1A52I1ziZF BjbIagXAo7Xy+Q12Qy9Yxr/HYcdqaZ0ZWh49Q+oub0iBuss= X-Google-Smtp-Source: APXvYqzgOgPvyT8Iruzjm0NRoATQ/vwYzJJVZAvZ+hu6Eb+DeduSjWQka4/IePMwIb72VKAhGaNQ41PiG79erNaR0Vc= X-Received: by 2002:a2e:81ca:: with SMTP id s10mr5721694ljg.181.1567091340970; Thu, 29 Aug 2019 08:09:00 -0700 (PDT) MIME-Version: 1.0 References: <20190829114057.GZ71821@kib.kiev.ua> <412537DD-D98F-4B92-85F5-CB93CF33F281@FreeBSD.org> <20190829144228.GA71821@kib.kiev.ua> In-Reply-To: Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Thu, 29 Aug 2019 23:08:49 +0800 Message-ID: Subject: Re: FCP 20190401-ci_policy: CI policy To: Kristof Provost Cc: Konstantin Belousov , FreeBSD Hackers , Li-Wen Hsu , fcp@freebsd.org X-Rspamd-Queue-Id: 46K5by52Vkz3JfT X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Aug 2019 15:09:02 -0000 Em qui, 29 de ago de 2019 =C3=A0s 23:03, Kristof Provost escreveu: > On 29 Aug 2019, at 16:42, Konstantin Belousov wrote: > > On Thu, Aug 29, 2019 at 02:03:00PM +0200, Kristof Provost wrote: > >> There are, somewhat regularly, commits which break functionality, or > >> at > >> the very least tests. > >> The main objective of this policy proposal is to try to improve > >> overall > >> code quality by encouraging and empowering all committers to > >> investigate > >> and fix test failures. > > But this policy does not encourage, if anything. > > It gives a free ticket to revert, discouraging committers. > > > To provide a counterpoint here: my personal frustration right now is > that I=E2=80=99ve spent a good bit of time adding tests for pf and fixing= bugs > for it, only to see the tests having to be disabled because of unrelated > (to pf) changes in the network stack. > > Either through lack of visibility, or lack of time, or because people > assume pf tests failures must by definition be the responsibility of the > pf maintainer, these failures have not been investigated by anyone other > than me, and I lack the time and subject matter expertise to fix them. > > I=E2=80=99m desperately afraid that if/when these bugs do get fixed we=E2= =80=99re > going to discover that other things have broken in the mean time, and > the tests are still going to fail, for different reasons. > > These are bugs. They=E2=80=99re the best case scenario for bug reports ev= en, > because they come with a reproduction case built-in, and yet they=E2=80= =99re > still not getting fixed. This too is discouraging. > > I=E2=80=99m open to alternative proposals for how to address that problem= , but > I don=E2=80=99t think that =E2=80=9Ccontinue on as we always have=E2=80= =9D is the correct > OK, because of PF that is sort of deprecated on FreeBSD and it need some new rules to make it workable, everybody else need to abdicate to some new rules. Yes, right you are!!!! > answer. > > Best regards, > Kristof > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " > --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)