From owner-svn-src-all@freebsd.org Sun Jul 29 17:45:02 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0012105C29F; Sun, 29 Jul 2018 17:45:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5EFB688C82; Sun, 29 Jul 2018 17:45:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w6THilP3002606 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 29 Jul 2018 20:44:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w6THilP3002606 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w6THiltg002605; Sun, 29 Jul 2018 20:44:47 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 29 Jul 2018 20:44:47 +0300 From: Konstantin Belousov To: Brad Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336845 - in head: etc etc/defaults etc/rc.d sbin/init sbin/init/rc.d Message-ID: <20180729174447.GJ40119@kib.kiev.ua> References: <201807282036.w6SKaNSi037944@repo.freebsd.org> <20180729154249.GG40119@kib.kiev.ua> <1532883687.1202573.1456550816.74531130@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532883687.1202573.1456550816.74531130@webmail.messagingengine.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 17:45:03 -0000 On Sun, Jul 29, 2018 at 11:01:27AM -0600, Brad Davis wrote: > On Sun, Jul 29, 2018, at 9:42 AM, Konstantin Belousov wrote: > > On Sat, Jul 28, 2018 at 08:36:23PM +0000, Brad Davis wrote: > > > Author: brd > > > Date: Sat Jul 28 20:36:23 2018 > > > New Revision: 336845 > > > URL: https://svnweb.freebsd.org/changeset/base/336845 > > > > > > Log: > > > Move rc startup scripts from etc/ to sbin/init/ > > Why all these moves are useful ? > > > > No commit message explained what is the goal of the moves, and why > > it is better that way comparing the existing src/etc collection. > > For pkg base we need to distill things out of etc/ and into places > where they fit better. This enables them to be pkged up with the > parts of the system them belong with and the CONFS= tags them as > config files so that pkg will know about them and be able to 3-way > merge them. This keeps the flexibility we have today with the many > WITH_*/WITHOUT_* knobs. Though it is not without trade offs, keeping > all of one part of the system together is simpler and makes some > maintenance easier. I do not see why do we need this for the pkgbase. There is nothing wrong with installation of the whole clean dist-supplied /etc on the fresh system. More, as you noted yourself, the ability to have all the config files installed is simpler and allows to overview and prepare configuration without requiring to have the corresponding packages installed. > > > Moving startup scripts to sbin/init is at least dubious, IMO. > > Startup scripts has nothing to do with init(8), but this is the > > second-order question. > > Do you have a better idea of a place for them? This is the most > logical place I could think of. rc scripts are definitely not configuration files. They are executables. I proposed this several times, the /etc/rc.d and /etc/rc.* are very much wrong place to contain the scripts. For instance, /libexec/rc/ could be more logical and much more operationally correct: e.g. the scripts can be updated by make installworld (or some sub-target) and removed by the ObsoleteFiles.