From owner-dev-commits-ports-all@freebsd.org Thu Apr 22 11:02:37 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B18D25EB4ED; Thu, 22 Apr 2021 11:02:37 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FQvdm6m9kz3k1r; Thu, 22 Apr 2021 11:02:36 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: by mail.evolve.de (OpenSMTPD) with ESMTP id 27ea7d2b; Thu, 22 Apr 2021 11:02:34 +0000 (UTC) Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id dc0a718f (TLSv1.3:AEAD-CHACHA20-POLY1305-SHA256:256:NO); Thu, 22 Apr 2021 11:02:34 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (1.0) Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. From: Michael Gmelin In-Reply-To: Date: Thu, 22 Apr 2021 13:02:33 +0200 Cc: Mathieu Arnold , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Message-Id: <6F9BF9EF-BA78-4E47-9A1C-3A022E2B6ED7@freebsd.org> References: To: Alexey Dokuchaev X-Mailer: iPhone Mail (18D70) X-Rspamd-Queue-Id: 4FQvdm6m9kz3k1r X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:24940, ipnet:213.239.192.0/18, country:DE]; local_wl_from(0.00)[freebsd.org] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 11:02:37 -0000 > On 22. Apr 2021, at 12:57, Alexey Dokuchaev wrote: >=20 > =EF=BB=BFOn Thu, Apr 22, 2021 at 12:49:14PM +0200, Mathieu Arnold wrote: >>> On Thu, Apr 22, 2021 at 10:43:46AM +0000, Alexey Dokuchaev wrote: >>> On Thu, Apr 22, 2021 at 12:16:16PM +0200, Mathieu Arnold wrote: >>>> On Thu, Apr 22, 2021 at 12:10:26PM +0200, Michael Gmelin wrote: >>>>> ... >>>>> I agree that author should only be used if a submission is applied >>>>> unaltered (pull request/git patch). >>>>=20 >>>> Submitted by has always been for submission that was unaltered (or only= >>>> slightly altered) if it was only the basis of the work, then "submitted= >>>> by" is not to be used, in those cases, reported by is the correct >>>> choice. >>>=20 >>> Not really, no. "PR:/Submitted by:" is canonical combination, yet most >>> of us modify submitted patches because they almost always need more work= . >>=20 >> Then you are misusing Submitted by. Submitted by was supposed to be >> used when you committed something that was, well, submitted by someone >> else. If the work is yours, and that you based your work on someone >> else's, then, it is not submitted by them. >=20 > No: "submitted" literally means there was actionable submission, i.e. > a patch. It could be good enough to be committed as is (rarely), or > require various amounts of polishing. Regardless of its quality, it > is still not merely a "report" as you would suggest. "Reports" are > sent by portscout or pkg-fallout. Users also send bug reports. I agree that it=E2=80=99s good to distinguish b= etween reporting ("it=E2=80=99s broken"), submitting a patch ("this fixed it= for me"), and accepting a patch unaltered ("this fixes it for everyone in a= clean way"). -m >=20 > ./danfe