From nobody Fri Apr 17 18:21:56 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fy3BD73QVz6WpD1 for ; Fri, 17 Apr 2026 18:21:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fy3BD4l2nz3vLX for ; Fri, 17 Apr 2026 18:21:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776450116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CCje9gkiyScVtqrF+pfbfCL9SzmZ7KNrH+JvwGefRzI=; b=kdFWJAkG7ayBqhBeV1ZJlQzFJk6LXVEUV139l71YS1aCU6ZXzmIS5Dak9JcUK7+wQRzIsA 8dulCNcALK4lADqIrk16PIW+ZhDxpenPjYnCc+T9NgPC5LiAAmWskxZoGMnYfJeTxdRlD1 AaUeRQ/YXSdEIZL2+hG4uPZc5QQ0xfgbEofpyVV0v7INlNBUakxnF0LZffPo45oN3Gjkij r8NRl/qccO7Febi9byX7JgaTXY2A1JqGyqrB+O0QzYzVZWibz5JIamO2IL3gqCp5bibwzO 6Zxk//WMqJTUa6VZpbkgruBhLBgna9Ylt7hZrNkQH1hJqtrJR7rFxnRTW4e7rA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776450116; a=rsa-sha256; cv=none; b=O1NfGUr/7wSuJ82VhKrRQBH5qi+TUjv5GnbXZ7hfKf+1xfpf2MBcaUSja+ZjiPbTSKvAuG dfkaMBEF4FWIgQIA0Vb3oD54j0C7TPOBS+haetPYYe7oHkkZu+0k9LA5Sms15kDNI2HH9x anmKpvvBsiKKXzJPZN6X4T1exoa88AFbSaiuv3IpwGUv+sk+ym5vxjAkBOn7oX/ZKG+KOK rZBYnOKiB5ipvpdHrNwTwfSbm1tlEmA8DBAhmZ4XZLhiozJrXfv6qJSD4oxfFq7XSnHqER GX6ni7cRnUnGgGe2EQDS2WbO6XNLm2b73n4h9E1dTZSeZu2sQp9vTwj/ghyJVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776450116; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CCje9gkiyScVtqrF+pfbfCL9SzmZ7KNrH+JvwGefRzI=; b=HJiJ7/nrN3dr+++TIj1YZt6n4aKRwmSWdw0EOOq/s15JSG0MkmqsDeg606El80M1aDcGlo MB3Hj6F6qu7ptZIq9YRfcXTaZkEqfbnCeozN5efCodNwe/V16hH3cNMsh0RE4htUQ6loh2 amXB8o6YRnr+idC3vk7KGZ+ZgyQ6de4eVHAv0sMgXsSa9Uvvo1yitef4mFF8gRKEuHBWuu RFVUk9zI+FoB7il7/Sk+O2Emja6IiS7aV9n/AWa9TmEMOEm3ITEJG4ON4BOnjaURKr4KUE +2oIdcn0fNmKQ9O9k5ETcMap7CouXh4C181FzkBI1Q0np0kPYYf2aj4NXvSqnA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fy3BD3clVz15BB for ; Fri, 17 Apr 2026 18:21:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3af4e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 17 Apr 2026 18:21:56 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Cc: Christos Longros From: Jose Luis Duran Subject: git: 9a4a9f623bba - main - ping6: treat setsockopt failures as fatal List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jlduran X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9a4a9f623bbaf991b3ba580593d47f2ee9f7b03b Auto-Submitted: auto-generated Date: Fri, 17 Apr 2026 18:21:56 +0000 Message-Id: <69e27a44.3af4e.6e191bfa@gitrepo.freebsd.org> The branch main has been updated by jlduran: URL: https://cgit.FreeBSD.org/src/commit/?id=9a4a9f623bbaf991b3ba580593d47f2ee9f7b03b commit 9a4a9f623bbaf991b3ba580593d47f2ee9f7b03b Author: Christos Longros AuthorDate: 2026-04-17 18:19:24 +0000 Commit: Jose Luis Duran CommitDate: 2026-04-17 18:19:39 +0000 ping6: treat setsockopt failures as fatal ping6 needs IPV6_RECVPKTINFO and IPV6_RECVHOPLIMIT to process incoming replies. When these options fail, replies are silently dropped and ping6 appears to hang. Use err(3) instead of warn(3) so the user gets a clear error and immediate exit. Signed-off-by: Christos Longros Reviewed by: pouria, jlduran, glebius MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D56237 --- sbin/ping/ping6.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/ping/ping6.c b/sbin/ping/ping6.c index 356f0f72a6f8..f81de062e59a 100644 --- a/sbin/ping/ping6.c +++ b/sbin/ping/ping6.c @@ -1083,21 +1083,21 @@ ping6(int argc, char *argv[]) #ifdef IPV6_RECVPKTINFO if (setsockopt(srecv, IPPROTO_IPV6, IPV6_RECVPKTINFO, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_RECVPKTINFO)"); /* XXX err? */ + err(1, "setsockopt(IPV6_RECVPKTINFO)"); #else /* old adv. API */ if (setsockopt(srecv, IPPROTO_IPV6, IPV6_PKTINFO, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_PKTINFO)"); /* XXX err? */ + err(1, "setsockopt(IPV6_PKTINFO)"); #endif #endif /* USE_SIN6_SCOPE_ID */ #ifdef IPV6_RECVHOPLIMIT if (setsockopt(srecv, IPPROTO_IPV6, IPV6_RECVHOPLIMIT, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_RECVHOPLIMIT)"); /* XXX err? */ + err(1, "setsockopt(IPV6_RECVHOPLIMIT)"); #else /* old adv. API */ if (setsockopt(srecv, IPPROTO_IPV6, IPV6_HOPLIMIT, &optval, sizeof(optval)) < 0) - warn("setsockopt(IPV6_HOPLIMIT)"); /* XXX err? */ + err(1, "setsockopt(IPV6_HOPLIMIT)"); #endif cap_rights_clear(&rights_srecv, CAP_SETSOCKOPT);