From nobody Sun Feb 19 23:43:30 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PKhvQ4NT7z3sF19; Sun, 19 Feb 2023 23:43:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PKhvQ3rYkz4Q1W; Sun, 19 Feb 2023 23:43:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676850210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iy8emTBlYOCTzsY+liw4ihATaatqVHA7QNSsTJyNnLA=; b=mMdd9i7330sYtIaHo+R2YwCwImKNIPhiHSBt8/+ZywltZxVrCBx1HB4jhMwdz68JA3kW0g 10MLESm/wew8Rtg2ZKuwteDs6/+1wt8j7hGEc6anIzVkTQlxUR9pkMOlShGJdEi2zQR5ET uS7cqdLv4t/yvav8sImC6+GUCSfWxhp6wwII/JeEfDO4fMYZaWs1IVSSrbSkoLUCnpTpRb 9U1pzd55rn9Li7uaUbyyPN8zpYbQ9EaFbjz2/gcJXJrPRZnHHy4cS9g6d/wPHXZxAxPd5K ocy/yQstrjKeTkNIFLBUZXgiR4xJB0Vgqxdhf0ti/4u43AT602pjZQeyBzJDZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676850210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iy8emTBlYOCTzsY+liw4ihATaatqVHA7QNSsTJyNnLA=; b=mzGqjjo0oqnCubh9BcPVbHv9A3PDseO0JdUp5SHkzcPQra6GLY0ytiA7JmFzIrOhep+W9P h4hOVWaI9IhKlUX8G0a3quXgV/9DV/pD3sPPhEbAI/Q4XQPtYfbpWnB5z0zEZcywIfTqDK RMxPSPzFxy9bOhZ2aiuQNIpDe/uzkhqJnvifR8A6HYMlWWqZpPntV0xlL6KRvT4Jzr9hs1 aRgO0WSLHGp6s9KXSZBAJ+iO78ho/d01YzSLRXCSJjVqZoZeo7SV8T3GfEjg0mfqLLk4Gz 7fOFTaSSmEIHKUlWlECwlXeStK27jdQ4/Cyt9cTxsR+dzqZZbWqbJf21nPjpXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676850210; a=rsa-sha256; cv=none; b=xS9ZLLYxprRKs4NwGAVM8ogA3vM5Yn+31ehIMK4xAKUS4Hh+rsOPOUSoPtcz9QSKQAu0KR fSpjZA3sc6DMrQN7NjXs2vuZ1aYfMItHe6ZIONs6uIzfOIu3kOETej7SFhkkOFVDhnpgLr OJd9LsQdsrdwP5JtYFCyLK1BeXOIImCY7iZBtVusCSlmKASoTY2tI9M/hOpXurdQSQ+eTz rrnsR+vMD7bXaMXiwB/V+AbblFkaouaDeNq5+ADsDmmGWaf3uHqoby+mkoq4a1m+gOcqXH fg6rUHnEVcUqSEv71SK5GBbHmNd/HnOk9vKDrJ6FYS2Y6zzfKgSNPantnC5IJQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PKhvQ2vwpzLKt; Sun, 19 Feb 2023 23:43:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 31JNhUuC035347; Sun, 19 Feb 2023 23:43:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 31JNhUYR035346; Sun, 19 Feb 2023 23:43:30 GMT (envelope-from git) Date: Sun, 19 Feb 2023 23:43:30 GMT Message-Id: <202302192343.31JNhUYR035346@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Alan Somers Subject: git: fbb102b2cec5 - releng/13.2 - fusefs: fix some resource leaks List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.2 X-Git-Reftype: branch X-Git-Commit: fbb102b2cec57181d0b00d81e8de384021f60ab0 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch releng/13.2 has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=fbb102b2cec57181d0b00d81e8de384021f60ab0 commit fbb102b2cec57181d0b00d81e8de384021f60ab0 Author: Alan Somers AuthorDate: 2023-02-11 23:43:30 +0000 Commit: Alan Somers CommitDate: 2023-02-19 23:42:32 +0000 fusefs: fix some resource leaks fusefs would leak tickets in three cases: * After FUSE_CREATE, if the server returned a bad inode number. * After a FUSE_FALLOCATE operation during VOP_ALLOCATE * After a FUSE_FALLOCATE operation during VOP_DEALLOCATE Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D38526 (cherry picked from commit 1bdf879b97b686a8f36fdba050b68f9e7493f363) MFC Note: changes to VOP_DEALLOCATE are not MFCed, because that VOP does not exist in stable/13. Approved by: re (cperciva) (cherry picked from commit 57756461548b813c288e190900de31e847e412f9) --- sys/fs/fuse/fuse_vnops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c index eaace113d67e..7fd96ff639ff 100644 --- a/sys/fs/fuse/fuse_vnops.c +++ b/sys/fs/fuse/fuse_vnops.c @@ -668,6 +668,7 @@ fuse_vnop_allocate(struct vop_allocate_args *ap) } } + fdisp_destroy(&fdi); return (err); } @@ -1104,6 +1105,7 @@ fuse_vnop_create(struct vop_create_args *ap) uint64_t nodeid = feo->nodeid; uint64_t fh_id = foo->fh; + fdisp_destroy(fdip); fdisp_init(fdip, sizeof(*fri)); fdisp_make(fdip, FUSE_RELEASE, mp, nodeid, td, cred); fri = fdip->indata;