Date: Tue, 26 Oct 1999 08:20:01 -0700 (PDT) From: Nate Williams <nate@mt.sri.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/14533: pccardd patch Message-ID: <199910261520.IAA59096@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/14533; it has been noted by GNATS.
From: Nate Williams <nate@mt.sri.com>
To: adamw@holonet.net
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/14533: pccardd patch
Date: Tue, 26 Oct 1999 09:15:20 -0600
> >Number: 14533
> >Category: bin
> >Synopsis: pccardd improperly assigns irqs
> >Confidential: no
> >Severity: non-critical
> >Priority: medium
> >Responsible: freebsd-bugs
> >State: open
> >Quarter:
> >Keywords:
> >Date-Required:
> >Class: change-request
> >Submitter-Id: current-users
> >Arrival-Date: Mon Oct 25 22:00:01 PDT 1999
> >Closed-Date:
> >Last-Modified:
> >Originator: Adam Wight
> >Release: FreeBSD 4.0-CURRENT i386
> >Organization:
> >Environment:
>
> >Description:
> pccardd sets the default irq mask for cards to the irq of the pcic
> instead of the configured irq that the resource file (pccard.conf) suggests.
>
This is necessary to avoid many races for suspend/remove.
>
> >Fix:
> Index: cardd.c
> ===================================================================
> RCS file: /usr/cvs/src/usr.sbin/pccard/pccardd/cardd.c,v
> retrieving revision 1.41
> diff -u -r1.41 cardd.c
> --- cardd.c 1999/08/28 01:17:35 1.41
> +++ cardd.c 1999/10/26 04:49:26
> @@ -559,7 +559,7 @@
> }
> strcpy(drv.name, drvp->kernel);
> drv.unit = drvp->unit;
> - drv.irqmask = 1 << sp->irq;
> + drv.irqmask = 1 << sp->config->irq;
> drv.flags = sp->config->flags;
> if (sp->flags & MEM_ASSIGNED) {
> drv.mem = sp->mem.addr;
>
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-bugs" in the body of the message
>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910261520.IAA59096>