From owner-svn-ports-all@FreeBSD.ORG Fri Apr 10 08:08:14 2015 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B15A1B0F; Fri, 10 Apr 2015 08:08:14 +0000 (UTC) Received: from mail-pd0-x229.google.com (mail-pd0-x229.google.com [IPv6:2607:f8b0:400e:c02::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7ECA4B71; Fri, 10 Apr 2015 08:08:14 +0000 (UTC) Received: by pdbqa5 with SMTP id qa5so15239870pdb.1; Fri, 10 Apr 2015 01:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:reply-to:subject:references:to:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=FmyQU60PfffSz7jdz9rzsgeynlUZKWBuLWTSVjJofuY=; b=CFfs6JE2OD5+SI5Mx1eHjfuEWlvtc6664w5X1bO6Cx0xARnANU8Y3VVcKCtfNDSkqn M7gt/8MKVnN9COR4aADTwlbw2dD2T5mbvkyKdlTtU2FMVvJy4Gl3bdodGp2N7BixU3YD hzUVbps8o171P70wVITG0hBbc9wGKeNAPxSb97fOUm66+unDIJXhj/vKa2d5n75rC4I8 MU6wOexFgBSBXiXRX06T3fuiwXtR1ACaUGZrCbyKU2gaDobqiyAn5Fwr8w40Po9ChHcw kOVzCmIk/jJhtSwa+231F8wucLRw90ALoYI4niGylHvFgMOgQqYYuq03zCHr2IV89vHJ vH4Q== X-Received: by 10.70.29.165 with SMTP id l5mr584876pdh.125.1428653294119; Fri, 10 Apr 2015 01:08:14 -0700 (PDT) Received: from [192.168.1.107] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id bz11sm1348179pdb.34.2015.04.10.01.08.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Apr 2015 01:08:13 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r383191 - head/Mk references: <20150408194202.GA45809@hades.panopticon> <5525A9C1.5010003@FreeBSD.org> <20150408232144.GX21982@hades.panopticon> <5525D48E.5090305@FreeBSD.org> <20150409110221.GB45809@hades.panopticon> <55269785.7030307@FreeBSD.org> <20150409153856.GA31951@FreeBSD.org> <55269FE4.2030208@FreeBSD.org> <20150409160330.GB31951@FreeBSD.org> <5526A52E.4090801@FreeBSD.org> <20150409162416.GA54797@FreeBSD.org> To: Bryan Drewery From: Kubilay Kocak message-id: <552784E3.8020401@FreeBSD.org> Date: Fri, 10 Apr 2015 18:08:03 +1000 user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:37.0) Gecko/20100101 Thunderbird/37.0 mime-version: 1.0 in-reply-to: <20150409162416.GA54797@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Dmitry Marakasov , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2015 08:08:14 -0000 On 10/04/2015 2:24 AM, Alexey Dokuchaev wrote: > On Thu, Apr 09, 2015 at 11:13:34AM -0500, Bryan Drewery wrote: >> On 4/9/2015 11:03 AM, Alexey Dokuchaev wrote: >>> On Thu, Apr 09, 2015 at 10:51:00AM -0500, Bryan Drewery wrote: >>>> Read the commit log again for r369644. Setting one var and not the other >>>> leads to incorrect behavior in many ports. You must have them matching. >>>> It is not just about jails/chroots. >>> >>> I've (re)read it and understand what you're trying to accomplish; my point >>> here is not to *build* things against custom OSVERSION, but just check if >>> some variables are set correctly, e.g. "make -V FOO OSVERSION=xxx" is what >>> I miss. Is there a way to allow it again somehow? >> >> I understand what you're trying to do and I agree it would be useful if >> it worked. Validating port logic (such as whether EXTRA_PATCHES has >> something) based on OSVERSION is very useful. I'll think about how to >> fix it. > > Right, EXTRA_PATCHES is a very good example. Good to know that there is > mutual understanding now and a chance for a fix. :) Thanks, > > ./danfe > +1 I've found myself many times debugging an individual port or ports framework logic issue checking everything is as it should be. Thank you Bryan