From nobody Mon Mar 10 20:49:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZBTY169Gcz5pdmC; Mon, 10 Mar 2025 20:49:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZBTY14mpyz479V; Mon, 10 Mar 2025 20:49:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741639797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=91rXpAmsMVCoEZS5bCj5WfuuWwgIhb7rwXANufbeoDQ=; b=UTHQon1qwg58ZY+Gfbds/ack+W56vnw0K3ld6Kq5F1tCPe0vDudHxQ+bB1YvdCPHT+beIz Z22Gq0imUOKFNCgsYb0toADnrcLAKxKIJfyxg9KX045nDtkzLXJB0+WFZ1Pfv35zT7+NiX ebsaayyUYJpmZRJOICzqXdyRxArMIGfGAQNceY2NCiitK9L7Z39S8U2mjuFE8cMddXxkn5 +2N4JWpQFzoTuRDKyewx1acwkDdJAVC/p8n/5b0SRCGLtjE2Qc+yirstTTUF2d1hn76OOZ xRBWEjvwm1MJEp4l+Di7qX2AW2orJ/KHo52mLD/LhEsinN4CnIKXQ4sVtNw4vg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741639797; a=rsa-sha256; cv=none; b=Fe95cSEwHymaIbaniWmIo/SLMP/z4x1Kekwb82k4E5ACIFLWCbRjQPT+PtR0abPOGhzMUB IA4nRYx+4XpC3C8GTDoDysigD6IWJIlw1Rkfb+f9Xi+JZlsvQO5tS2nX+5rPQlvqgth0a2 +OaFG7wbWJ9slUvl4qh3Xsstd0I7V3k6BXLePVYMPfvwrzyvZC5wFpnMe/VrHo04ZvR17n uCIMVSq8r7orD/5JFBv8BZzeturJp7tcjwThCaFigrlL1LkzTtNiHsqeMzdFCbUrLH6iQQ xAQeRAmUbGLpVh+oEFwVzSMxmusxLMVSlOxE5sFI8yXlYT0xfajc41MXlJNfZw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741639797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=91rXpAmsMVCoEZS5bCj5WfuuWwgIhb7rwXANufbeoDQ=; b=pHpC+sj2UEYDXsBwPJK/JcV/wmY+7YyFQ1sKaWEgsGMlh+zRdg5sDWDxtChm4KpUgp+mmq KiljJQNAZ1H+1Yled7zKp3jdxqaCq0winXxtvIEwmRGA7ceJ/q8nulUDigHnvMKZEsi7S5 fSTBpZe/6L+jOwT5ChX1G4HYcgHyKgmX4kNOaYZPbm5VyAkOGsRC2wPvSeir1K+6WR390p TZCd8xeoNomROd35+ARg4y8x0/VsT39hTxHFeK1ghVnBc034yy9qTrEYv/j6Uk8PxFF3ca o4/nv22sC6Aj4jHMAY86ORb3Tc7TqsCP8NZfrhgmG800xlJcRHi6ZzDAlsa2pQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZBTY14NPLzvS3; Mon, 10 Mar 2025 20:49:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 52AKnvkT083684; Mon, 10 Mar 2025 20:49:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 52AKnviB083681; Mon, 10 Mar 2025 20:49:57 GMT (envelope-from git) Date: Mon, 10 Mar 2025 20:49:57 GMT Message-Id: <202503102049.52AKnviB083681@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: b768f2c7773b - main - sound: Retire SD_F_AUTOVCHAN List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b768f2c7773b6e306fb43687657414f9f42a27d4 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=b768f2c7773b6e306fb43687657414f9f42a27d4 commit b768f2c7773b6e306fb43687657414f9f42a27d4 Author: Christos Margiolis AuthorDate: 2025-03-10 20:47:35 +0000 Commit: Christos Margiolis CommitDate: 2025-03-10 20:47:35 +0000 sound: Retire SD_F_AUTOVCHAN This flag is redundant and essentially a no-op, as it is set when the device supports at least playback or recording, which is almost always the case. But even if the device is mixer-only (i.e., 0 channels), there is no reason to keep this flag; it is only used to bail out of the vchan sysctl handlers, but we already bail out anyway if we try to use the sysctl in a vchan direction that is not supported. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D49021 --- sys/dev/sound/pcm/sound.c | 7 +------ sys/dev/sound/pcm/sound.h | 4 ++-- sys/dev/sound/pcm/vchan.c | 8 ++++---- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/sys/dev/sound/pcm/sound.c b/sys/dev/sound/pcm/sound.c index 3e76626f5c57..5759c06725ce 100644 --- a/sys/dev/sound/pcm/sound.c +++ b/sys/dev/sound/pcm/sound.c @@ -369,8 +369,7 @@ pcm_sysinit(device_t dev) OID_AUTO, "mode", CTLFLAG_RD, NULL, mode, "mode (1=mixer, 2=play, 4=rec. The values are OR'ed if more than " "one mode is supported)"); - if (d->flags & SD_F_AUTOVCHAN) - vchan_initsys(dev); + vchan_initsys(dev); if (d->flags & SD_F_EQ) feeder_eq_initsys(dev); } @@ -430,10 +429,6 @@ pcm_register(device_t dev, char *str) if (d->playcount == 0 || d->reccount == 0) d->flags |= SD_F_SIMPLEX; - - if (d->playcount > 0 || d->reccount > 0) - d->flags |= SD_F_AUTOVCHAN; - if (d->playcount > 0) d->flags |= SD_F_PVCHANS; if (d->reccount > 0) diff --git a/sys/dev/sound/pcm/sound.h b/sys/dev/sound/pcm/sound.h index df08b1700869..7f17c710038a 100644 --- a/sys/dev/sound/pcm/sound.h +++ b/sys/dev/sound/pcm/sound.h @@ -99,7 +99,7 @@ struct snd_mixer; #define SOUND_MAXVER SOUND_MODVER #define SD_F_SIMPLEX 0x00000001 -#define SD_F_AUTOVCHAN 0x00000002 +/* unused 0x00000002 */ #define SD_F_SOFTPCMVOL 0x00000004 #define SD_F_BUSY 0x00000008 #define SD_F_MPSAFE 0x00000010 @@ -122,7 +122,7 @@ struct snd_mixer; #define SD_F_BITS "\020" \ "\001SIMPLEX" \ - "\002AUTOVCHAN" \ + /* "\002 */ \ "\003SOFTPCMVOL" \ "\004BUSY" \ "\005MPSAFE" \ diff --git a/sys/dev/sound/pcm/vchan.c b/sys/dev/sound/pcm/vchan.c index 27739fe68852..2b300e90ea4d 100644 --- a/sys/dev/sound/pcm/vchan.c +++ b/sys/dev/sound/pcm/vchan.c @@ -260,7 +260,7 @@ sysctl_dev_pcm_vchans(SYSCTL_HANDLER_ARGS) int err, enabled, flag; d = devclass_get_softc(pcm_devclass, VCHAN_SYSCTL_UNIT(oidp->oid_arg1)); - if (!PCM_REGISTERED(d) || !(d->flags & SD_F_AUTOVCHAN)) + if (!PCM_REGISTERED(d)) return (EINVAL); PCM_LOCK(d); @@ -318,7 +318,7 @@ sysctl_dev_pcm_vchanmode(SYSCTL_HANDLER_ARGS) char dtype[16]; d = devclass_get_softc(pcm_devclass, VCHAN_SYSCTL_UNIT(oidp->oid_arg1)); - if (!PCM_REGISTERED(d) || !(d->flags & SD_F_AUTOVCHAN)) + if (!PCM_REGISTERED(d)) return (EINVAL); PCM_LOCK(d); @@ -409,7 +409,7 @@ sysctl_dev_pcm_vchanrate(SYSCTL_HANDLER_ARGS) int *vchanrate, direction, ret, newspd, restart; d = devclass_get_softc(pcm_devclass, VCHAN_SYSCTL_UNIT(oidp->oid_arg1)); - if (!PCM_REGISTERED(d) || !(d->flags & SD_F_AUTOVCHAN)) + if (!PCM_REGISTERED(d)) return (EINVAL); PCM_LOCK(d); @@ -508,7 +508,7 @@ sysctl_dev_pcm_vchanformat(SYSCTL_HANDLER_ARGS) char fmtstr[AFMTSTR_LEN]; d = devclass_get_softc(pcm_devclass, VCHAN_SYSCTL_UNIT(oidp->oid_arg1)); - if (!PCM_REGISTERED(d) || !(d->flags & SD_F_AUTOVCHAN)) + if (!PCM_REGISTERED(d)) return (EINVAL); PCM_LOCK(d);