From owner-freebsd-wireless@freebsd.org Mon May 16 22:08:52 2016 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED600B38BB3 for ; Mon, 16 May 2016 22:08:52 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B8C751F9B; Mon, 16 May 2016 22:08:52 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x22d.google.com with SMTP id i75so748528ioa.3; Mon, 16 May 2016 15:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-transfer-encoding; bh=Gkt/2njwZT/Qucwvd91WsLamDvVaSrCqXRpW69jJFBo=; b=QVNbQaRpO9tMExng8zofuJZeuDchllP5i8A1JeVGboqmG/qVsRtQFapMAIOVifqtSt PJ7RR7ZEXOAicFC0S+n15FTHpskXnmxY+dYhsSJYY1ECG1LU4VD+bzbyl6ZPwyb1DCxs I63lbTKZ2TNvSThglYYEDK0UoYxa0nTfaMbz0cszbVX7YVQexV7frkyfszE3WGzIjtkc xVpBpwROR4aiVNJIDooNkckcfM1fbr30KW3dVwSm+GLPE30nybhA2SIvaKx+khaoQGoy 4JHnzXSbX2Joh/twrknnTbmveBwuoE1RiDzwF/XCxKGWEkekPE7JatnmDmQU7fIfZH9S yERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-transfer-encoding; bh=Gkt/2njwZT/Qucwvd91WsLamDvVaSrCqXRpW69jJFBo=; b=i74cZZ8cwSi8ByVglUPqCkzTHD8R7nRmXhK+DNYSyqO1UPI7tbYPniyWIc03Zgip3p NEesGN1vV/kfbSJbywFPRGZeurXZoKB3RfQ99CHGQtVsjCyM48zfKOjrbymPsEr2ZT8q Dx/PezC5B+FIGFKQupZ1baH9OCHSQH1ESqZhnq7GS7yEItqpy2++Qq6pbf05pJkGt9Fv rNHONXPadaHHZ9JFJud5Nbdtt1S+p4GExTbIfD8ZmPHwgf3FTz8E48LOa7FxzzA4A+O+ XgMu0CBCSaPUeuAJuR4XUQgyua0Sjr0yzgDsN/Iq9UpFOWofWhStEFB24KUSAByO9rHt 3ovA== X-Gm-Message-State: AOPr4FVB/YnUGRLUSL1peZ4v5FwK+rKko3Hz4zxzaQJVluNEBPctctopxyZX5CGFjNWqGQHa0KilsZx9Yc0TkA== MIME-Version: 1.0 X-Received: by 10.36.81.79 with SMTP id s76mr10900889ita.71.1463436532255; Mon, 16 May 2016 15:08:52 -0700 (PDT) Received: by 10.36.113.3 with HTTP; Mon, 16 May 2016 15:08:52 -0700 (PDT) In-Reply-To: References: <201605162142.u4GLgs8d072880@gw.catspoiler.org> Date: Mon, 16 May 2016 15:08:52 -0700 Message-ID: Subject: Re: minor array overflow in ifconfig set80211chanlist() From: Adrian Chadd To: Andriy Voskoboinyk Cc: Don Lewis , "freebsd-wireless@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 22:08:53 -0000 On 16 May 2016 at 15:05, Andriy Voskoboinyk wrote: > Tue, 17 May 2016 01:03:03 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd > : > >> Heh, god, it's used for both maximum ieee channel number /and/ the >> array size? we should eventually fix that; 11ac channels will likely >> overflow all of the above. :( > > > No (yes) :) > I mean ic->ic_nchans and nitems(ic->ic_channels) > ... but you are right: ic_ieee is uint8_t, so it's limited by this number > too. Right. Well, for 11ac they still have the IEEE number, but they also have separate frequency definitions in the IEs for upper/lower 80MHz and the configuration therein. -adrian