From owner-cvs-src@FreeBSD.ORG Tue Nov 22 13:18:22 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9C5AB16A420; Tue, 22 Nov 2005 13:18:22 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4077443D70; Tue, 22 Nov 2005 13:18:19 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 2418591 for multiple; Tue, 22 Nov 2005 08:17:00 -0500 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jAMDGfUE076921; Tue, 22 Nov 2005 08:16:44 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Daniel O'Connor" Date: Tue, 22 Nov 2005 08:16:39 -0500 User-Agent: KMail/1.8.3 References: <200511212022.jALKMZQA069772@repoman.freebsd.org> <200511221004.35442.doconnor@gsoft.com.au> In-Reply-To: <200511221004.35442.doconnor@gsoft.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200511220816.41471.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/puc puc.c src/sys/alpha/conf DEFAULTS src/sys/amd64/conf DEFAULTS src/sys/i386/conf DEFAULTS src/sys/ia64/conf DEFAULTS src/sys/pc98/conf DEFAULTS src/sys/sparc64/conf DEFAULTS X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2005 13:18:22 -0000 On Monday 21 November 2005 06:34 pm, Daniel O'Connor wrote: > On Tue, 22 Nov 2005 06:52, John Baldwin wrote: > > Don't enable PUC_FASTINTR by default in the source. Instead, enable = it > > via the DEFAULTS kernel configs. This allows folks to turn it that > > option off in the kernel configs if desired without having to hack the > > source. This is especially useful since PUC_FASTINTR hangs the kernel > > boot on my ultra60 which has two uart(4) devices hung off of a puc(4) > > device. > > > > I did not enable PUC_FASTINTR by default on powerpc since powerpc does > > not currently allow sharing of INTR_FAST with non-INTR_FAST like the > > other archs. > > Why not make it a tunable? > > Untested but compilable patch attached. *shrug* You can if you want. One thing I would suggest is cutting down on= =20 the code duplication if you go this route and doing something like this: if (fast_intr) irq_setup =3D bus_setup_intr(..., INTR_TYPE_TTY | INTR_FAST); if (!fast_intr || irq_setup !=3D 0) irq_setup =3D bus_setup_intr(..., INTR_TYPE_TTY); That has less indentation and less duplicated code and is easier to read I= =20 think. Granted, I'm not sure how many people would actually use this tunab= le=20 in 7.0 since INTR_FAST breaks in fewer places now since for all but ppc=20 INTR_FAST can be shared with !INTR_FAST. =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org