From owner-cvs-all@FreeBSD.ORG  Thu Feb 26 17:46:26 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DDF2116A4CE
	for <cvs-all@FreeBSD.org>; Thu, 26 Feb 2004 17:46:26 -0800 (PST)
Received: from mailhub2.midco.net (mailhub2.midco.net [24.220.0.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6966F43D2D
	for <cvs-all@FreeBSD.org>; Thu, 26 Feb 2004 17:46:26 -0800 (PST)
	(envelope-from pmes@bis.midco.net)
Received: (qmail 20634 invoked by uid 0); 27 Feb 2004 02:46:26 -0000
Received: from host-195-219-220-24.midco.net (HELO bis.midco.net)
	([24.220.219.195])          (envelope-sender <pmes@bis.midco.net>)
	by lvs-pop.midco.net (qmail-ldap-1.03) with SMTP
	for <kris@obsecurity.org>; 27 Feb 2004 02:46:26 -0000
Message-ID: <403EA170.9080100@bis.midco.net>
Date: Thu, 26 Feb 2004 19:46:24 -0600
From: Peter Schultz <pmes@bis.midco.net>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7a) Gecko/20040226
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kris Kennaway <kris@obsecurity.org>
References: <200402251000.i1PA0nGn056196@repoman.freebsd.org>
	<403E0B90.9040106@bis.midco.net> <20040226203351.GB5915@xor.obsecurity.org>
In-Reply-To: <20040226203351.GB5915@xor.obsecurity.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: jkoshy@FreeBSD.org
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/graphics/xaos Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2004 01:46:27 -0000

Kris Kennaway wrote:
> On Thu, Feb 26, 2004 at 09:06:56AM -0600, Peter Schultz wrote:
> 
>>Kris Kennaway wrote:
>>
>>>kris        2004/02/25 02:00:49 PST
>>>
>>> FreeBSD ports repository
>>>
>>> Modified files:
>>>   graphics/xaos        Makefile 
>>> Log:
>>> BROKEN on 5.x !i386 and !amd64: Does not compile
>>> 
>>> Revision  Changes    Path
>>> 1.20      +7 -1      ports/graphics/xaos/Makefile
>>>
>>
>>Well, I don't have a patch for the broken build, but I do have one to 
>>enable thread support.  I'm not sure if the Makefile is as complete as 
>>it should be with my patch, but it does work.
>>
>>I could definitely tell there was a performance increase by enabling 
>>multi-threading.  Xaos rocks!  Mmmmmm, eye candy.
>>
>>Pete...
> 
> 
>>*** /usr/ports/graphics/xaos/Makefile	Thu Feb 26 08:44:54 2004
>>--- Makefile	Thu Feb 26 08:44:20 2004
>>***************
>>*** 30,35 ****
>>--- 30,39 ----
>>  CONFIGURE_ARGS=	--with-svga-driver=no
>>  .endif
>>  
>>+ .if defined(WITH_THREADS)
>>+ CONFIGURE_ARGS+= --with-pthread=yes
>>+ .endif
>>+ 
> 
> 
> And does this do the right thing with PTHREAD_{CFLAGS,LIBS} on 4.x and 5.x?
> 
> Kris

I'm not sure, I copied the functionality from the textproc/libxml2 
Makefile.  I'm only assuming it "Just Works".  What should I be looking 
out for?

Pete...