From owner-svn-src-head@FreeBSD.ORG  Mon Mar  8 22:12:17 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id 2653F1065673;
	Mon,  8 Mar 2010 22:12:17 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Date: Mon, 8 Mar 2010 17:11:42 -0500
User-Agent: KMail/1.6.2
References: <201003081940.o28JeVG1088074@svn.freebsd.org>
	<201003081611.42854.jhb@freebsd.org>
In-Reply-To: <201003081611.42854.jhb@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201003081712.00635.jkim@FreeBSD.org>
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r204877 - head/sys/modules/acpi/acpi
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Mar 2010 22:12:17 -0000

On Monday 08 March 2010 04:11 pm, John Baldwin wrote:
> On Monday 08 March 2010 2:40:31 pm Jung-uk Kim wrote:
> > Author: jkim
> > Date: Mon Mar  8 19:40:31 2010
> > New Revision: 204877
> > URL: http://svn.freebsd.org/changeset/base/204877
> >
> > Log:
> >   Enable ACPI module build on amd64.  Although we strongly
> > recommend building it into kernel, there is no need to prevent it
> > from building at all.
>
> (Oops, ignore previous spurious reply).
>
> Please revert this.  The MADT parser on amd64 is slightly different
> from i386 and will not work when acpi is loaded as a module.  If
> anything, I would prefer we make acpi not be a module on i386. 
> There are several things that would be far less invasive to
> implement via #ifdef DEV_ACPI than by defining runtime kobj
> interfaces to the ACPI driver.

madt.c itself is not very different but I understand what you are 
trying to explain here.  In fact, I tested it before committing and 
the trick was adding mptable in place of acpi.  It worked fine 
although it may not be ideal.  I can back out 
sys/modules/acpi/Makefile change if you agree, however.

Jung-uk Kim