From owner-dev-commits-src-main@freebsd.org Tue May 4 01:42:07 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 31D795FCFD4; Tue, 4 May 2021 01:42:07 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FZ2dV0s5Vz4RDb; Tue, 4 May 2021 01:42:05 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from disco.vangyzen.net (unknown [70.97.188.230]) by smtp.vangyzen.net (Postfix) with ESMTPSA id E61E956488; Mon, 3 May 2021 20:41:58 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=vangyzen.net; s=default; t=1620092519; bh=EDbJBjHJDbDEHDIza9qlZG8fhYdw3tlTUMfqpSAfjlI=; h=Subject:To:References:From:Date:In-Reply-To; b=aJ3rMqW4cTqQ6ncea5wf2TS0cy6QWcIwisBy0QmgghsEmRyuBQ6suFv0hVKvEMsu9 MceJtr0u7oazsyZ3G5MG1Iry4p/HaDXDkmWs2ApVHbvc8w9+UQni35JB8CyKJqEGad SDryHRGky9UorfXlcvpswWqS4pMMO/0sD4YmybyTlypIBdwXwFmQZuMU7phYZRgd53 dVAfMDBsr0skA6rV5puDGqt+7ExcZRz9uEKed6gZ9hP1u66pvYIAeL01vXwbBQhY5J YlSbr5EHiTT52qn5GLUofQJtSHvIN2IC233rIdRqDXTTjfHuEGbG7uz0ASoRem+bDA Sr5yh8zdtf94A== Subject: Re: ee8b757a949a - main - ipmi: support getting address from EFI To: Ravi Pokala , Eric van Gyzen , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202104291525.13TFPCQR020414@gitrepo.freebsd.org> From: Eric van Gyzen Message-ID: <7c68e6f9-29c4-71a6-c172-465fc8dda9e3@vangyzen.net> Date: Mon, 3 May 2021 20:41:55 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4FZ2dV0s5Vz4RDb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=vangyzen.net header.s=default header.b=aJ3rMqW4; dmarc=pass (policy=none) header.from=vangyzen.net; spf=pass (mx1.freebsd.org: domain of eric@vangyzen.net designates 199.48.133.146 as permitted sender) smtp.mailfrom=eric@vangyzen.net X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[vangyzen.net:s=default]; FREEFALL_USER(0.00)[eric]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCPT_COUNT_FIVE(0.00)[5]; SPAMHAUS_ZRD(0.00)[199.48.133.146:from:127.0.2.255]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DKIM_TRACE(0.00)[vangyzen.net:+]; DMARC_POLICY_ALLOW(-0.50)[vangyzen.net,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[199.48.133.146:from]; ASN(0.00)[asn:36236, ipnet:199.48.132.0/22, country:US]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2021 01:42:07 -0000 > URL: https://cgit.FreeBSD.org/src/commit/?id=ee8b757a949a9575c7355ea01f0475e0c526b9e5 > > commit ee8b757a949a9575c7355ea01f0475e0c526b9e5 > > ipmi: support getting address from EFI > > I get why the MODULE_DEPEND() was added to ipmi_smbios.c: it's now making an efirt call. But why was it added to the other three files? Those other files call the function that calls into efirt. I don’t know if the explicit dependencies were actually necessary, but since they’re logically correct, I figure they don’t hurt. Eric