From owner-svn-src-user@freebsd.org Fri Oct 7 23:46:38 2016 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B61DC05822 for ; Fri, 7 Oct 2016 23:46:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pa0-x243.google.com (mail-pa0-x243.google.com [IPv6:2607:f8b0:400e:c03::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6444F9CD; Fri, 7 Oct 2016 23:46:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pa0-x243.google.com with SMTP id cd13so3353307pac.3; Fri, 07 Oct 2016 16:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IQgcJ0c6F6HN3avtAzylQggqtRssGust73X5Gasg6Vo=; b=NckIlF3T3ZyLGuxhi8bGTRNULQ4S/+i8YtGsy6S2v1tSriGKBjREGoFe/nVGI9VjVL Dv28Mm8RBOEgtMHb74SJRJ4Bcv81+KNUBbWt/IjyxIyNmMGKGSPI6MUTtIa6tR3GiZhV ystXPXb+q33LqkkKKPc/EqbXHOWZeNNnua+sF3PaZjw+e/zGQC4v4s7hjgUUDKADW4+M u/MdUt43vgyxXjdQFhQGqLsvFlwPr6cIqZmHQrZ5YQoC4MPKrpFvdgbXgBMDmh8n2nPK pWTHGIKYbH+JT8gwht39Nk1W9X2tUz8lM5pWBLMwNHcC2KWmrlNdr7WHHZEGy5kHf/NP bV0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=IQgcJ0c6F6HN3avtAzylQggqtRssGust73X5Gasg6Vo=; b=j/tAizEo/Yu8Jo0kxXKhCufe63tqPfQn3Y8SR5od8QjCXqyKuDz8so+9SslhDmEEG0 kLgTuN/mq1b5yp9w06p0FDB5ycVlyB7FztR+nYDOrSEgMOY9hetuS9hIF9NEO5bBnP06 mZmFzRpcZ9JDZ82/pgH6e7uuBzAXUmNy0NDs9gwHfkv8OT92VkpS4CIDtj3S/Hh8H1In FE4V7dp6Rnwcu0Vaotb2s+GI52IsCIJiXJ7ALKp3n+3ecbeQWhpb3fcl/jzofAQi2N52 kvoQ99mCQT/mJ9BbOW/i4xk6Qcavt+AeCLw9NPn4l/pgetfhx2hHSSGWGoFsF41sb6sw l1gw== X-Gm-Message-State: AA6/9RlO9mBpfTeajHnNC9uS7r9hw/GA7uj1opvnBYjwbjJ/c2Kmapx1XdFuY44fxAJz8A== X-Received: by 10.66.16.74 with SMTP id e10mr1056243pad.148.1475883997872; Fri, 07 Oct 2016 16:46:37 -0700 (PDT) Received: from wkstn-mjohnston.west.isilon.com (c-76-104-201-218.hsd1.wa.comcast.net. [76.104.201.218]) by smtp.gmail.com with ESMTPSA id s29sm16585999pfi.55.2016.10.07.16.46.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 16:46:37 -0700 (PDT) Sender: Mark Johnston Date: Fri, 7 Oct 2016 16:52:36 -0700 From: Mark Johnston To: Bruce Evans Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r306831 - in user/alc/PQ_LAUNDRY/usr.bin: systat vmstat Message-ID: <20161007235236.GC65501@wkstn-mjohnston.west.isilon.com> References: <201610072217.u97MHh08042582@repo.freebsd.org> <20161008093219.O2989@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161008093219.O2989@besplex.bde.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 23:46:38 -0000 On Sat, Oct 08, 2016 at 10:35:59AM +1100, Bruce Evans wrote: > On Fri, 7 Oct 2016, Mark Johnston wrote: > > > Log: > > Teach vmstat and systat about v_pdshortfalls. > > systat has a negative amount of space available for expansion. Hm, I see. I'll revert the systat modifications then. It isn't particularly handy to have the rate of shortfall wakeups given what's already available in the vmstat display. > > > Modified: user/alc/PQ_LAUNDRY/usr.bin/systat/vmstat.c > > ============================================================================== > > --- user/alc/PQ_LAUNDRY/usr.bin/systat/vmstat.c Fri Oct 7 22:17:25 2016 (r306830) > > +++ user/alc/PQ_LAUNDRY/usr.bin/systat/vmstat.c Fri Oct 7 22:17:43 2016 (r306831) > > @@ -339,14 +340,15 @@ labelkre(void) > > mvprintw(VMSTATROW + 8, VMSTATCOL + 9, "react"); > > mvprintw(VMSTATROW + 9, VMSTATCOL + 9, "pdwak"); > > mvprintw(VMSTATROW + 10, VMSTATCOL + 9, "pdpgs"); > > - mvprintw(VMSTATROW + 11, VMSTATCOL + 9, "intrn"); > > - mvprintw(VMSTATROW + 12, VMSTATCOL + 9, "wire"); > > - mvprintw(VMSTATROW + 13, VMSTATCOL + 9, "act"); > > - mvprintw(VMSTATROW + 14, VMSTATCOL + 9, "inact"); > > - mvprintw(VMSTATROW + 15, VMSTATCOL + 9, "laund"); > > - mvprintw(VMSTATROW + 16, VMSTATCOL + 9, "free"); > > - if (LINES - 1 > VMSTATROW + 17) > > - mvprintw(VMSTATROW + 17, VMSTATCOL + 9, "buf"); > > + mvprintw(VMSTATROW + 11, VMSTATCOL + 9, "pdshort"); > > + mvprintw(VMSTATROW + 12, VMSTATCOL + 9, "intrn"); > > + mvprintw(VMSTATROW + 13, VMSTATCOL + 9, "wire"); > > + mvprintw(VMSTATROW + 14, VMSTATCOL + 9, "act"); > > + mvprintw(VMSTATROW + 15, VMSTATCOL + 9, "inact"); > > + mvprintw(VMSTATROW + 16, VMSTATCOL + 9, "laund"); > > + mvprintw(VMSTATROW + 17, VMSTATCOL + 9, "free"); > > + if (LINES - 1 > VMSTATROW + 18) > > + mvprintw(VMSTATROW + 18, VMSTATCOL + 9, "buf"); > > > > mvprintw(GENSTATROW, GENSTATCOL, " Csw Trp Sys Int Sof Flt"); > > Already the display of 'buf' was broken by expansion: on freefall now: > > 30 users Load 0.21 0.18 0.13 Oct 7 22:32 > Mem usage: 82%Phy 10%Kmem > Mem: KB REAL VIRTUAL VN PAGER SWAP PAGER > Tot Share Tot Share Free in out in out > Act 784512 23764 7319516 42640 4515744 count > All 893752 129672 7995532 624636 pages > Proc: Interrupts > r p d s w Csw Trp Sys Int Sof Flt ioflt 569 total > 422 3216 49 362 232 33 5 1 cow uart0 4 > 2 zfod 29 cpu0:timer > 0.3%Sys 0.0%Intr 0.0%User 0.0%Nice 99.7%Idle ozfod 4 igb0:que 0 > | | | | | | | | | | %ozfod 1 igb0:que 1 > daefr 12 igb0:que 2 > 1 dtbuf 93 prcfr 1 igb0:que 3 > Namei Name-cache Dir-cache 485980 desvn 117 totfr 10 igb0:que 4 > Calls hits % hits % 485400 numvn react 1 igb0:que 5 > 17 17 100 179227 frevn pdwak 1 igb0:que 6 > 147 pdpgs 4 igb0:que 7 > Disks da0 da1 da2 da3 da4 da5 da6 intrn igb0:link > KB/t 20.12 19.75 19.75 20.00 19.62 20.00 0.00 5096864 wire 196 ciss0 274 > tps 31 31 31 31 31 31 0 330628 act 27 cpu1:timer > MB/s 0.61 0.60 0.60 0.60 0.59 0.60 0.00 14524764 inact 6 cpu18:time > %busy 15 13 16 16 18 15 0 cache 7 cpu8:timer > 4515744 free 3 cpu10:time > 2 cpu16:time > > 'buf' is not important, but 'free' is. > > The last line is not available for the main display, but is used for the > cpu16:time. This line is used for input, > so and everything displayed on it is cleared for input and then messed up > in an uglier way by redisplaying only parts (for the cpu16: field, the > count is re-displayed on screen refresh but the description is not > re-displayed without a switch to another screen and back). > > The interrupts column and the input line are generally broken. With > 24 CPUs and also some other per-cpu interrupt counts, it takes about > a 200-row terminal to display all the interrupts and then 1 more row > to stop the input line running into the interrupts. The rest of the > display is tuned for 25 rows and looks strange when it is 7/8 unused. > Per-CPU interrupts are also miscounted in totals... > > Bruce