Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 6 May 2018 14:19:51 +0000 (UTC)
From:      Michael Tuexen <tuexen@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r333304 - head/sys/netinet
Message-ID:  <201805061419.w46EJpj3094778@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tuexen
Date: Sun May  6 14:19:50 2018
New Revision: 333304
URL: https://svnweb.freebsd.org/changeset/base/333304

Log:
  Ensure we are not dereferencing a NULL pointer.
  
  This was found by Coverity scanning the usrsctp stack (CID 203808).
  
  MFC after:	3 days

Modified:
  head/sys/netinet/sctp_indata.c

Modified: head/sys/netinet/sctp_indata.c
==============================================================================
--- head/sys/netinet/sctp_indata.c	Sun May  6 13:59:56 2018	(r333303)
+++ head/sys/netinet/sctp_indata.c	Sun May  6 14:19:50 2018	(r333304)
@@ -3621,7 +3621,9 @@ sctp_strike_gap_ack_chunks(struct sctp_tcb *stcb, stru
 						    SCTP_SO_NOT_LOCKED);
 					}
 					/* Make sure to flag we had a FR */
-					tp1->whoTo->net_ack++;
+					if (tp1->whoTo != NULL) {
+						tp1->whoTo->net_ack++;
+					}
 					continue;
 				}
 			}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805061419.w46EJpj3094778>