From owner-svn-src-all@freebsd.org Fri Nov 13 21:43:48 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90E39A2E3E9; Fri, 13 Nov 2015 21:43:48 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 710A31485; Fri, 13 Nov 2015 21:43:48 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 644DA1833; Fri, 13 Nov 2015 21:43:48 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 1C2AB16D48; Fri, 13 Nov 2015 21:43:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 3nokw7EVyLEV; Fri, 13 Nov 2015 21:43:45 +0000 (UTC) Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 892A616D41 To: Randall Stewart References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <56465003.8070709@FreeBSD.org> <4A4A2115-6392-487A-BEBE-499A68689D4A@netflix.com> Cc: "Alexander V. Chernikov" , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Adrian Chadd , imp@freebsd.org From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <56465991.5090906@FreeBSD.org> Date: Fri, 13 Nov 2015 13:43:45 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 21:43:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: quoted-printable On 11/13/2015 1:24 PM, Randall Stewart wrote: > Looking at the patch, we need a define of your >=20 > _callout_stop_safe >=20 > and we need to switch >=20 > callout_stop()=92s define to use the new _callout_stop_safe() For both cases, there would be no reason to have new code call my wrapper. The defines in my patch are fine for new code. The "new" _callout_stop_safe function is just for existing modules. I think the historical consensus is to not commit my patch though as people should recompile their modules when the kernel is updated, before rebooting into the new kernel even. >=20 > R > On Nov 13, 2015, at 4:20 PM, Randall Stewart > wrote: >=20 >> No alexander=92s panic=92s are because the >> LLREF >> is done if (callout_stop()) >> >> But now if it was not running -1 is returned.. >> >> Try the patch I just sent.. >> >> R >> On Nov 13, 2015, at 4:02 PM, Bryan Drewery > > wrote: >> >>> On 11/13/2015 1:00 PM, Randall Stewart wrote: >>>> Bryan: >>>> >>>> This looks like a decent thing to do.. >>>> >>>> Still wondering why changing the callout.h header file would not >>>> have caused >>>> things to recompile to pick up the new argument.. >>>> >>>> We can do it this way though it looks fine. >>>> >>>> You want to commit it or I? >>> >>> Well your change is totally safe for compiling. It's just not KBI >>> backwards compat for older modules. This is not typically a problem b= ut >>> I think in this case it is worth doing to avoid random data coming in= to >>> the 'drain' argument if loading an older module. >>> >>> I'll do a test build and commit it. Perhaps this is what was leading = to >>> Alexander's panics. >>> >>> I haven't analyzed the return value issue at all. >>> >>> --=20 Regards, Bryan Drewery --uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRlmRAAoJEDXXcbtuRpfPX6EH/RW325PZr6YxDWWyxgac5lj5 AE6VtdT8Df6wiF8lC+Jv5VwgzT7xG+SC21K/wXjsxIkivtyug3PEbUyASz6CmUTv /onaL9cwFL9+ozIoJTGXSKgT7PQRQbbalQmYgXe5DY+DuZU9j1ij/WbFcgSZ9w8f ySjH41nqTgN0JicD7PyaM8Dj+tmWKa/+ZFYr5WMyqIvJ/7LNltmftbstAuL8OiGo +s2bD24QB2SgMiD7+t70mbHcv76eyeku+ZV+H9Oo1HraCqcw76uKjrrSt6fwMfnL Nyiaohho69XVLhWEFIgmbtFEvpcVtu4t4ttM9OyITkOr0JjT6cXajFzwxcU6Fjg= =pVGx -----END PGP SIGNATURE----- --uRGlu0WMxOdm89LDmBTvN3SS6NevFDrkc--