From owner-cvs-all@FreeBSD.ORG Fri Jun 15 16:46:43 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 80B9A16A46F; Fri, 15 Jun 2007 16:46:43 +0000 (UTC) (envelope-from lwhsu@FreeBSD.csie.nctu.edu.tw) Received: from FreeBSD.csie.nctu.edu.tw (freebsd.csie.nctu.edu.tw [140.113.17.209]) by mx1.freebsd.org (Postfix) with ESMTP id 21C9913C4BC; Fri, 15 Jun 2007 16:46:43 +0000 (UTC) (envelope-from lwhsu@FreeBSD.csie.nctu.edu.tw) Received: from localhost (unknown [127.0.0.1]) by FreeBSD.csie.nctu.edu.tw (Postfix) with ESMTP id 8DB347EB96; Sat, 16 Jun 2007 00:49:03 +0800 (CST) Received: from FreeBSD.csie.nctu.edu.tw ([127.0.0.1]) by localhost (FreeBSD.csie.nctu.edu.tw [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RlLNGL3J9rAx; Sat, 16 Jun 2007 00:49:01 +0800 (CST) Received: by FreeBSD.csie.nctu.edu.tw (Postfix, from userid 1058) id BBE847EB99; Sat, 16 Jun 2007 00:49:01 +0800 (CST) Date: Sat, 16 Jun 2007 00:49:01 +0800 From: Li-Wen Hsu To: infofarmer@FreeBSD.org Message-ID: <20070615164901.GA86604@FreeBSD.csie.nctu.edu.tw> References: <200706151428.l5FESrEq080128@repoman.freebsd.org> <20070615142857.64CA516A498@hub.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-06) Cc: cvs-ports@freebsd.org, YUAN Jue , cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/devel/kdesvn Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 16:46:43 -0000 --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 15, 2007 at 19:37:15 +0400, Andrew Pantyukhin wrote: > > -MAINTAINER=3D yuanjue@yuanjue.net > > +MAINTAINER=3D yuanjue@freebsd.org >=20 > We have a policy of capitalizing our project's name as > "FreeBSD" where possible. From prior discussions, I > remember there might be some trademark issues involved, > and at least for some time after the new logo has been > accepted, some developers were quite sure it's not a > style issue, but rather a mandatory policy. Thanks for notification. Since this change is come from the PR, I'll change it after approved by YUAN Jue. > > +.if !defined(NOPORTDOCS) > > +DOCSDIR=3D ${PREFIX}/share/doc/HTML/en/kdesvn > > .endif >=20 > Is there any merit to this DOCSDIR definition being > conditional? Seems no. Sometimes I put this in the Makefile: =2Eif !defined(NOPORTDOCS) DOCSDIR=3D /some/other/place PORTDOCS=3D * =2Eendif This gives me a bad habit to write DOCSDIR definition like this, I'll be aware next time. Also, I'll change this after getting maintainer's approval. > Thanks! Thanks. Besides, though I don't really care where the review goes. (I am very happy with this) But since some people don't like this. How about replying the commit in private, and maintaining a "Common Mistakes when Porting" list, after a number of items collected? Posting it to ports@ list and put into the porter's handbook might be a good idea. This can get more porters' attention, and easier to find. Sometimes, looking for something in the high-traffic mailing list is quite hard. After all, not everyone read every commit message and its reply, but every should read the handbook (and read again when it is updated), right? Thanks for your comment, again. --=20 Best Regards, Li-Wen Hsu --17pEHd4RhPHOinZp Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGcsL8QWsOOSiXsigRAhxLAJ463KB5w2NDikrlyHDxfXmaRaXf0gCeIXKl KuzprmrWQfqUDbWEbE0lMbc= =RfCS -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--