From owner-svn-src-all@freebsd.org Fri May 6 15:09:22 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E22FBB31A66; Fri, 6 May 2016 15:09:22 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A522F1F37; Fri, 6 May 2016 15:09:22 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u46F9L80098766; Fri, 6 May 2016 15:09:21 GMT (envelope-from pfg@FreeBSD.org) Received: (from pfg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u46F9Lr7098764; Fri, 6 May 2016 15:09:21 GMT (envelope-from pfg@FreeBSD.org) Message-Id: <201605061509.u46F9Lr7098764@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: pfg set sender to pfg@FreeBSD.org using -f From: "Pedro F. Giffuni" Date: Fri, 6 May 2016 15:09:21 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r299176 - head/sys/dev/usb/wlan X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 15:09:23 -0000 Author: pfg Date: Fri May 6 15:09:21 2016 New Revision: 299176 URL: https://svnweb.freebsd.org/changeset/base/299176 Log: dev/usb: unsigned some loop indexes. Although usually small, values produced by nitems() are unsigned. By unsigning the corresponding indexes we avoid signed vs unsigned comparisons. This may have some effect on performance, although given the small sizes the effect will not be perceivable, and it makes the code clearer. Respect the style of the changed files: one uses u_int while the other uses "unsigned int". Reviewed by: hselasky Modified: head/sys/dev/usb/wlan/if_run.c head/sys/dev/usb/wlan/if_urtw.c Modified: head/sys/dev/usb/wlan/if_run.c ============================================================================== --- head/sys/dev/usb/wlan/if_run.c Fri May 6 13:45:42 2016 (r299175) +++ head/sys/dev/usb/wlan/if_run.c Fri May 6 15:09:21 2016 (r299176) @@ -5222,7 +5222,7 @@ run_rssi2dbm(struct run_softc *sc, uint8 static void run_rt5390_bbp_init(struct run_softc *sc) { - int i; + u_int i; uint8_t bbp; /* Apply maximum likelihood detection for 2 stream case. */ @@ -5332,7 +5332,7 @@ run_rt3070_rf_init(struct run_softc *sc) { uint32_t tmp; uint8_t bbp4, mingain, rf, target; - int i; + u_int i; run_rt3070_rf_read(sc, 30, &rf); /* toggle RF R30 bit 7 */ @@ -5476,7 +5476,7 @@ run_rt3593_rf_init(struct run_softc *sc) { uint32_t tmp; uint8_t rf; - int i; + u_int i; /* Disable the GPIO bits 4 and 7 for LNA PE control. */ run_read(sc, RT3070_GPIO_SWITCH, &tmp); @@ -5525,7 +5525,7 @@ run_rt5390_rf_init(struct run_softc *sc) { uint32_t tmp; uint8_t rf; - int i; + u_int i; /* Toggle RF R2 to initiate calibration. */ if (sc->mac_ver == 0x5390) { Modified: head/sys/dev/usb/wlan/if_urtw.c ============================================================================== --- head/sys/dev/usb/wlan/if_urtw.c Fri May 6 13:45:42 2016 (r299175) +++ head/sys/dev/usb/wlan/if_urtw.c Fri May 6 15:09:21 2016 (r299176) @@ -1910,7 +1910,7 @@ fail: static uint16_t urtw_rate2rtl(uint32_t rate) { - int i; + unsigned int i; for (i = 0; i < nitems(urtw_ratetable); i++) { if (rate == urtw_ratetable[i].reg) @@ -1923,7 +1923,7 @@ urtw_rate2rtl(uint32_t rate) static uint16_t urtw_rtl2rate(uint32_t rate) { - int i; + unsigned int i; for (i = 0; i < nitems(urtw_ratetable); i++) { if (rate == urtw_ratetable[i].val) @@ -2450,7 +2450,7 @@ fail: static usb_error_t urtw_8225_rf_init(struct urtw_softc *sc) { - int i; + unsigned int i; uint16_t data; usb_error_t error; @@ -2831,7 +2831,7 @@ fail: static usb_error_t urtw_8225v2_rf_init(struct urtw_softc *sc) { - int i; + unsigned int i; uint16_t data; uint32_t data32; usb_error_t error; @@ -3164,7 +3164,7 @@ static usb_error_t urtw_8225v2b_rf_init(struct urtw_softc *sc) { struct ieee80211com *ic = &sc->sc_ic; - int i; + unsigned int i; uint8_t data8; usb_error_t error;