From owner-svn-ports-head@freebsd.org Sun Jul 28 12:10:58 2019 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF3B1AA179; Sun, 28 Jul 2019 12:10:58 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B0BF92D89; Sun, 28 Jul 2019 12:10:58 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-pl1-f181.google.com with SMTP id ay6so26466064plb.9; Sun, 28 Jul 2019 05:10:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/2KfkzzH94e6oaF3CCPr2eTa2V5MzMowpboRnSLgWlU=; b=jD9s9JzC0+PiXgrX+ibIwcKnf9+6KQX8d+gdFhE2GCi3sEVNYYZmFPJ68fkuLpmyz6 Euj9p16qVq0lULqKy31kw9OK/ahYVI8v/MGosxkTRkbOH758tR4KLvIxaaAxu7gO3w6l 8LdeTGkRRSn/5X/WnaqlTewtlaiFUOW9gqk9kOBW+5po5U25+x0zaMiQS/Y1HYaKwu1p 65Fr5jp0i2zZrttRfE2Wm5I2y7vE/6Ouxq27GEuS3RptTLJWh0hRbNg1ISEuZJIb8J6e JmMIEaZ/0xI3ydUtFBSCy6AHAz8f7xXDXU5878Mh8tH7QfKSyKNmBudiLttdu5fagrU+ 7D4Q== X-Gm-Message-State: APjAAAVQ0MRJm6wkE0kljm7iQscAVzE8lw4HrNiavsMXXpfSCZMaaqL4 RoOPTsH15Qujf4zY5+qp12+3tZhyJ3o= X-Google-Smtp-Source: APXvYqzKOIpTS2aYbXp6Us8GLBtKoX3zSKTIgYBNc+kUVC7Ervjh1e45fpjLsC4h4sqzZD2txi9r4w== X-Received: by 2002:a17:902:ba8b:: with SMTP id k11mr104529418pls.107.1564309197260; Sun, 28 Jul 2019 03:19:57 -0700 (PDT) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com. [209.85.210.175]) by smtp.gmail.com with ESMTPSA id s3sm19247544pgq.17.2019.07.28.03.19.56 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jul 2019 03:19:56 -0700 (PDT) Received: by mail-pf1-f175.google.com with SMTP id r1so26540550pfq.12; Sun, 28 Jul 2019 03:19:56 -0700 (PDT) X-Received: by 2002:aa7:90d8:: with SMTP id k24mr30807033pfk.115.1564309196490; Sun, 28 Jul 2019 03:19:56 -0700 (PDT) MIME-Version: 1.0 References: <201907261652.x6QGqoxC018196@repo.freebsd.org> <20190727055121.GA99138@urd.tobik.me> In-Reply-To: <20190727055121.GA99138@urd.tobik.me> From: Gleb Popov Date: Sun, 28 Jul 2019 14:19:30 +0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r507361 - head/Mk/Uses To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 0B0BF92D89 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=6yearold@gmail.com X-Spamd-Result: default: False [-5.28 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.973,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-3.11)[ip: (-9.64), ipnet: 209.85.128.0/17(-3.42), asn: 15169(-2.44), country: US(-0.05)]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.19)[-0.190,0]; RCVD_IN_DNSWL_NONE(0.00)[181.214.85.209.list.dnswl.org : 127.0.5.0]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; MIME_TRACE(0.00)[0:+,1:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2019 12:10:58 -0000 On Sat, Jul 27, 2019 at 9:51 AM Tobias Kortkamp wrote: > On Fri, Jul 26, 2019 at 04:52:50PM +0000, Gleb Popov wrote: > > Author: arrowd > > Date: Fri Jul 26 16:52:49 2019 > > New Revision: 507361 > > URL: https://svnweb.freebsd.org/changeset/ports/507361 > > > > Log: > > Add support for USES= cabal:hpack and document this option. > > > > Modified: > > head/Mk/Uses/cabal.mk > > > > Modified: head/Mk/Uses/cabal.mk > > > ============================================================================== > > --- head/Mk/Uses/cabal.mk Fri Jul 26 16:46:46 2019 (r507360) > > +++ head/Mk/Uses/cabal.mk Fri Jul 26 16:52:49 2019 (r507361) > > @@ -2,9 +2,13 @@ > > # > > # Provide support for building Haskell packages using Cabal. > > # > > -# Feature: cabal > > -# Usage: USES=cabal > > +# Feature: cabal > > +# Usage: USES=cabal or USES=cabal:ARGS > > +# Valid ARGS: hpack > > # > > +# hpack: The port doesn't have a .cabal file and needs > devel/hs-hpack to > > +# generate it from package.yaml file > > +# > > # Variables, which can be set by the port: > > # > > # USE_CABAL List of Haskell packages required to build a port. > > @@ -36,10 +40,6 @@ > > .if !defined(_INCLUDE_USES_CABAL_MK) > > _INCLUDE_USES_CABAL_MK= yes > > > > -.if !empty(cabal_ARGS) > > -IGNORE= Incorrect 'USES= cabal:${cabal_ARGS}' cabal takes > no arguments > > -.endif > > - > > Nothing checks USES=cabal args now and it accepts any garbage > arguments like USES=cabal:asdfasd. Please put back some check for > invalid arguments. > Does https://svnweb.freebsd.org/changeset/ports/507506 look good for you? > Index: Mk/Uses/cabal.mk > =================================================================== > --- Mk/Uses/cabal.mk (revision 507380) > +++ Mk/Uses/cabal.mk (working copy) > @@ -40,6 +40,10 @@ > .if !defined(_INCLUDE_USES_CABAL_MK) > _INCLUDE_USES_CABAL_MK= yes > > +.if !empty(cabal_ARGS:Nhpack) > +IGNORE= USES=cabal has invalid arguments: ${cabal_ARGS:Nhpack} > +.endif > + > PKGNAMEPREFIX?= hs- > > EXECUTABLES?= ${PORTNAME} > > >