From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Mar 21 00:20:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 04CD41065670 for ; Sat, 21 Mar 2009 00:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BA87D8FC15 for ; Sat, 21 Mar 2009 00:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n2L0K1LM070141 for ; Sat, 21 Mar 2009 00:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n2L0K1X6070140; Sat, 21 Mar 2009 00:20:01 GMT (envelope-from gnats) Resent-Date: Sat, 21 Mar 2009 00:20:01 GMT Resent-Message-Id: <200903210020.n2L0K1X6070140@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Scot W. Hetzel" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 507CD106566C for ; Sat, 21 Mar 2009 00:11:40 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 3F3AD8FC16 for ; Sat, 21 Mar 2009 00:11:40 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n2L0Bek8052803 for ; Sat, 21 Mar 2009 00:11:40 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n2L0BdJF052802; Sat, 21 Mar 2009 00:11:39 GMT (envelope-from nobody) Message-Id: <200903210011.n2L0BdJF052802@www.freebsd.org> Date: Sat, 21 Mar 2009 00:11:39 GMT From: "Scot W. Hetzel" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/132887: net/samba3: Invalid value for SUB_LIST variable. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2009 00:20:02 -0000 >Number: 132887 >Category: ports >Synopsis: net/samba3: Invalid value for SUB_LIST variable. >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Mar 21 00:20:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Scot W. Hetzel >Release: 8.0-CURRENT >Organization: >Environment: >Description: The following code taken from net/samba3*/Makefile. This code has an error: .if !defined(WITHOUT_WINBIND) CONFIGURE_ARGS+= --with-winbind PLIST_SUB+= WINBIND="" SUB_LIST+= WINBIND="" .else CONFIGURE_ARGS+= --without-winbind PLIST_SUB+= WINBIND="@comment " SUB_LIST+= WINBIND="@comment " .endif The SUB_LIST is being used to replace %%WINBIND%% in ${FILESDIR}/samba.in. When the WINBIND option is off, it cause %%WINBIND%% to be replaced with '@comment ' in the shell script file. Instead it should have replaced %%WINBIND%% with the shell comment character "#" instead. NOTE: This problem affects all 3 samba ports: net/samba3 net/samba32 net/samba33 >How-To-Repeat: Install net/samba3 with the WINBIND option off. >Fix: Replace '@comment ' with '#' for the WINBIND SUB_LIST entry. >Release-Note: >Audit-Trail: >Unformatted: