From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Mar 9 11:40:10 2007 Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG> X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A74C116A403 for <freebsd-ports-bugs@hub.freebsd.org>; Fri, 9 Mar 2007 11:40:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 7FF6013C442 for <freebsd-ports-bugs@hub.freebsd.org>; Fri, 9 Mar 2007 11:40:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l29BeAFY002312 for <freebsd-ports-bugs@freefall.freebsd.org>; Fri, 9 Mar 2007 11:40:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l29BeAYw002311; Fri, 9 Mar 2007 11:40:10 GMT (envelope-from gnats) Resent-Date: Fri, 9 Mar 2007 11:40:10 GMT Resent-Message-Id: <200703091140.l29BeAYw002311@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Simon Phoenix<phoenix.lists@gmail.com> Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D657116A401 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 9 Mar 2007 11:39:10 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id BE57013C461 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 9 Mar 2007 11:39:10 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l29BdAuk040835 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 9 Mar 2007 11:39:10 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l29BdANv040834; Fri, 9 Mar 2007 11:39:10 GMT (envelope-from nobody) Message-Id: <200703091139.l29BdANv040834@www.freebsd.org> Date: Fri, 9 Mar 2007 11:39:10 GMT From: Simon Phoenix<phoenix.lists@gmail.com> To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: ports/110125: portmaster 1.15 bug in find_and_delete_distfiles function X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs> List-Post: <mailto:freebsd-ports-bugs@freebsd.org> List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe> X-List-Received-Date: Fri, 09 Mar 2007 11:40:10 -0000 >Number: 110125 >Category: ports >Synopsis: portmaster 1.15 bug in find_and_delete_distfiles function >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Mar 09 11:40:10 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Simon Phoenix >Release: 6.2-STABLE >Organization: Phoenix Lab. >Environment: FreeBSD sp0-host.lan 6.2-STABLE FreeBSD 6.2-STABLE #0: Sat Feb 10 22:05:58 EET 2007 phoenix@sp0-host.lan:/usr/obj/usr/src/sys/PHOENIX i386 >Description: Little bug in find_and_delete_distfiles function in portmaster 1.15. When portmaster find and delete disfiles i have this message: [...] install-info --quiet /usr/local/info/standards261.info /usr/local/info/dir ===> Compressing manual pages for autoconf-2.61 ===> Registering installation for autoconf-2.61 ===> Cleaning for autoconf-2.61 ===>>> Upgrade for devel/autoconf261 to autoconf-2.61 succeeded [: grep: unexpected operator ===>>> Delete autoconf-000227.tar.bz2? [n] [: grep: unexpected operator ===>>> Delete autoconf-2.53.tar.bz2? [n] [...] More detailed report (with set -vx in bash): + [ ! -d autoconf-2.53.tar.bz2 ] + grep -q (autoconf-2.53.tar.bz2) /tmp/DI-FILES-5309.3yIGg13X + [ -n ] + echo -n ===>>> Delete autoconf-2.53.tar.bz2? [n] ===>>> Delete autoconf-2.53.tar.bz2? [n] + read DELORNOT + [ ! -d autoconf-2.59.tar.bz2 ] + grep -q (autoconf-2.59.tar.bz2) /tmp/DI-FILES-5309.3yIGg13X + [ -n ] + echo -n ===>>> Delete autoconf-2.59.tar.bz2? [n] ===>>> Delete autoconf-2.59.tar.bz2? [n] + read DELORNOT >How-To-Repeat: Just try update software. >Fix: Fix find_and_delete_distfiles function with patch. (Sorry, I can't attach patch, I just paste it here.) --- /usr/local/sbin/portmaster Fri Mar 9 05:13:00 2007 +++ /usr/home/phoenix/projects/patches/portmaster Fri Mar 9 13:07:00 2007 @@ -684,7 +684,7 @@ continue # Do not delete current version ;; *) [ ! -d "$file" ] || continue - [ grep -q \(${file}\) $DI_FILES ] && continue + grep -q \(${file}\) $DI_FILES && continue if [ -n "$ALWAYS_SCRUB_DISTFILES" ]; then echo "===>>> Deleting stale distfile: $file" >Release-Note: >Audit-Trail: >Unformatted: