From nobody Wed Mar 2 03:03:11 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8623519F2B2D for ; Wed, 2 Mar 2022 04:30:36 +0000 (UTC) (envelope-from ari@ish.com.au) Received: from mail.ish.com.au (203-129-16-229.cb8110.syd.nbn.aussiebb.net [203.129.16.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4K7h4V5dXYz3GHf for ; Wed, 2 Mar 2022 04:30:34 +0000 (UTC) (envelope-from ari@ish.com.au) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ish.com.au; s=mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References: To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gIeGiDptDT+e15CCXeVyxwE6pMtfbbesslQIUzzHvFc=; b=ZpaU0Q+yprnECTEez+oKuipF8M u3+hMjkBfs4P1HF/tLW2BTAgFd6wjtGGYjJm7y95ZEP1ZNMjRaCF9YqrLc5tLzPS2qz94cluHoQFC zYpN3kVT/Rn7bSkhARjRuRC/7W2pX2Qf8M0XlHTWA7fOIPquo/fmIQs6SPhrnijI5bUY4QnR0FNpI 490r63I1km4ihWg+f0F6dLCxnILUd7aRw9vs+mC28yKJ5S/F3kFUnFGZNWOLRZHsmkQoVp8Gd4CGG QM0MR9WGtqt5poC0uNFYH8FGR2StEsi15WlhwUBI6E05o/210qBf+5F1dj58q7R83SH7FYVVLNrik hVBN9h4g==; Received: from [10.29.63.10] by mail.ish.com.au with esmtpsa (TLS1.3) tls TLS_AES_128_GCM_SHA256 (Exim 4.95 (FreeBSD)) (envelope-from ) id 1nPFGA-0002EE-00; Wed, 02 Mar 2022 14:03:11 +1100 Message-ID: <73971ae1-ea72-311b-bd53-0532aa6cdbd0@ish.com.au> Date: Wed, 2 Mar 2022 14:03:11 +1100 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: pkgs contain non URL safe characters Content-Language: en-US To: Ronald Klop , freebsd-ports@FreeBSD.org References: <378a27ca-dbfe-d6f4-45f6-2ff90265874e@ish.com.au> From: Aristedes Maniatis In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4K7h4V5dXYz3GHf X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ish.com.au header.s=mail header.b=ZpaU0Q+y; dmarc=pass (policy=quarantine) header.from=ish.com.au; spf=pass (mx1.freebsd.org: domain of ari@ish.com.au designates 203.129.16.229 as permitted sender) smtp.mailfrom=ari@ish.com.au X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[ish.com.au:s=mail]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-0.997]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ish.com.au:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[ish.com.au,quarantine]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-ports]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:4764, ipnet:203.129.16.0/22, country:AU]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 1/3/2022 10:57pm, Ronald Klop wrote: > > You could try the untested patch below as "compatibility fix", but I'm > not sure if that will not break other valid URLs passed to fetch/pkg. > Apparently pkg embeds libfetch statically: > https://github.com/freebsd/pkg/tree/master/external/libfetch . > This patch is against the FreeBSD base. > > diff --git a/lib/libfetch/fetch.c b/lib/libfetch/fetch.c > index 82a3c5e451a..496425cea47 100644 > --- a/lib/libfetch/fetch.c > +++ b/lib/libfetch/fetch.c > @@ -451,7 +451,7 @@ fetchParseURL(const char *URL) >                 } >                 u->doc = doc; >                 while (*p != '\0') { > -                       if (!isspace((unsigned char)*p)) { > +                       if (!isspace((unsigned char)*p) && *p != '+') { >                                 *doc++ = *p++; >                         } else { >                                 *doc++ = '%'; > Thanks for that. I think there are both static and normal versions of pkg. The static binary is at pkg-static for bootstrapping a system which might be missing libraries. Since I don't want to be patching the system libs on all our servers, I think I'll keep my poudriere hook hack for now. If the openjdk port maintainers are on this list, please consider removing the + from the package names. An underscore might do equally well. Thanks for your help and insight. Ari