From owner-freebsd-net Wed Aug 22 22: 3:40 2001 Delivered-To: freebsd-net@freebsd.org Received: from InterJet.elischer.org (c421509-a.pinol1.sfba.home.com [24.7.86.9]) by hub.freebsd.org (Postfix) with ESMTP id 52B0737B401; Wed, 22 Aug 2001 22:03:34 -0700 (PDT) (envelope-from julian@elischer.org) Received: from elischer.org (InterJet.elischer.org [192.168.1.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id WAA50973; Wed, 22 Aug 2001 22:04:58 -0700 (PDT) Message-ID: <3B8489F6.2F1EF3A6@elischer.org> Date: Wed, 22 Aug 2001 21:43:34 -0700 From: Julian Elischer X-Mailer: Mozilla 4.7 [en] (X11; U; FreeBSD 5.0-CURRENT i386) X-Accept-Language: en, hu MIME-Version: 1.0 To: Mike Silbersack Cc: Dave Zarzycki , freebsd-net@freebsd.org Subject: Re: RFC: SACK/FACK patch port to Current References: Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 7bit Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Mike Silbersack wrote: > > On Wed, 22 Aug 2001, Dave Zarzycki wrote: > > > Attached and tested. > > > > I'd like to merge this in unless anybody objects. > > > > davez > > > > -- > > Dave Zarzycki > > I haven't done any testing of this code, but having SACK support would > certainly be nice, so I think committing it to -current with the intention > of a long testing period before mfcing is a good idea. > > However, before that is done, I think some changes should be made; all the > #ifdef SACK and #ifdef FACKs are ugly. They should be taken out, and > runtime tuneables (defaulting to on) should be added around the pieces of > code that actually control SACK and FACK initialization at socket setup > time. This will ensure that it gets wide testing, and at the same time > will allow people who suspect that it is causing problems to still turn it > off. > > Once those changes are made, it's probably best to have 2-3 other > committers test and review before committing. I usually add a new feature with #ifdefs for the first few weeks and take them out after I'm confident that it's safe.. > > Mike "Silby" Silbersack > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-net" in the body of the message -- +------------------------------------+ ______ _ __ | __--_|\ Julian Elischer | \ U \/ / hard at work in | / \ julian@elischer.org +------>x USA \ a very strange | ( OZ ) \___ ___ | country ! +- X_.---._/ presently in San Francisco \_/ \\ v To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message