Date: Fri, 5 Apr 2002 14:59:01 -0800 (PST) From: John Baldwin <jhb@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 9146 for review Message-ID: <200204052259.g35Mx1s13232@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=9146 Change 9146 by jhb@jhb_laptop on 2002/04/05 14:58:05 Merge from jhb_proc: remove a weird diagnostic leftover from KSE. Also, we don't need Giant for suser() now. Affected files ... ... //depot/projects/smpng/sys/kern/kern_acct.c#12 edit Differences ... ==== //depot/projects/smpng/sys/kern/kern_acct.c#12 (text+ko) ==== @@ -119,14 +119,12 @@ struct nameidata nd; int error, flags; - mtx_lock(&Giant); - if (td != curthread) - panic("acct"); /* XXXKSE DIAGNOSTIC */ /* Make sure that the caller is root. */ error = suser(td); if (error) - goto done2; + return (error); + mtx_lock(&Giant); /* * If accounting is to be started to a file, open that file for * writing and make sure it's a 'normal'. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200204052259.g35Mx1s13232>