From owner-freebsd-bugs  Sat Nov  9 14:20:06 1996
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id OAA24702
          for bugs-outgoing; Sat, 9 Nov 1996 14:20:06 -0800 (PST)
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id OAA24688;
          Sat, 9 Nov 1996 14:20:03 -0800 (PST)
Resent-Date: Sat, 9 Nov 1996 14:20:03 -0800 (PST)
Resent-Message-Id: <199611092220.OAA24688@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, mark@linus.demon.co.uk
Received: from janai.thuvia.org (linus.demon.co.uk [158.152.10.220])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id OAA24546
          for <FreeBSD-gnats-submit@freebsd.org>; Sat, 9 Nov 1996 14:17:22 -0800 (PST)
Received: (from mark@localhost) by janai.thuvia.org (8.8.2/8.8.2) id WAA18201; Sat, 9 Nov 1996 22:16:33 GMT
Message-Id: <199611092216.WAA18201@janai.thuvia.org>
Date: Sat, 9 Nov 1996 22:16:33 GMT
From: Mark Valentine <mark@linus.demon.co.uk>
Reply-To: mark@linus.demon.co.uk
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/1986: error in lpr(1) argument handling [with fix]
Sender: owner-bugs@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk


>Number:         1986
>Category:       bin
>Synopsis:       error in lpr(1) argument handling [with fix]
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov  9 14:20:01 PST 1996
>Last-Modified:
>Originator:     Mark Valentine
>Organization:
>Release:        FreeBSD 3.0-CURRENT i386
>Environment:

	n/a

>Description:

	There's an off-by-one error in lpr(1)'s default jobname code.

>How-To-Repeat:

	``lpr /etc/motd'' with banner page enabled; job name will be
	random garbage.

>Fix:

[first hunk is irrelevant cosmetic adjustment]
	
--- lpr.c.ctm	Fri Nov  8 04:12:51 1996
+++ lpr.c	Sat Nov  9 22:01:56 1996
@@ -76,7 +76,7 @@
 
 static char	*cfname;	/* daemon control files, linked from tf's */
 static char	*class = host;	/* class title on header page */
-static char	*dfname;		/* data files */
+static char	*dfname;	/* data files */
 static char	*fonts[4];	/* troff font names */
 static char	 format = 'f';	/* format char for printing files */
 static int	 hdr = 1;	/* print header or not (default is yes) */
@@ -285,10 +285,10 @@
 	card('P', person);
 	if (hdr) {
 		if (jobname == NULL) {
-			if (argc == 1)
+			if (argc == 0)
 				jobname = "stdin";
 			else
-				jobname = (arg = rindex(argv[1], '/')) ? arg+1 : argv[1];
+				jobname = (arg = rindex(argv[0], '/')) ? arg+1 : argv[0];
 		}
 		card('J', jobname);
 		card('C', class);

>Audit-Trail:
>Unformatted: