Date: Sat, 18 Apr 2020 01:25:02 +0000 From: Vidar Karlsen <vidar@karlsen.tech> To: Hiroki Tagato <tagattie@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: editors/atom: build error on 13.0-CURRENT Message-ID: <3d0282d3-c574-c9dc-a7bb-d0473ebae57e@karlsen.tech> In-Reply-To: <ee43d8c8-9b0e-581b-530b-9c2ed0e99248@FreeBSD.org> References: <81db6f61-fde7-bf88-9e25-bcdd78cd5db9@karlsen.tech> <3461B7A1-41EC-4233-9861-8045E03E8AF3@FreeBSD.org> <4d0b5c27-b38f-1ef3-4629-0a9390777524@karlsen.tech> <ee43d8c8-9b0e-581b-530b-9c2ed0e99248@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4/17/20 7:24 AM, Hiroki Tagato wrote: > > Can you apply a patch at https://github.com/nodejs/node/pull/29541 and > try to build again? If it goes well, I will update the port to include > the patch. > > Thanks, > Hiroki It passes the configure phase with that change to the regex, but it fails later. Running 'make' in /usr/ports/editors/atom: [...] c++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.8"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I../deps/v8 -I../deps/v8/include -pthread -Wall -Wextra -Wno-unused-parameter -m64 -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 -fno-strict-aliasing -I/usr/local/include -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /usr/ports/editors/atom/work/node-v10.2.1/out/Release/.deps//usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_init/deps/v8/src/setup-isolate-full.o.d.raw -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -c -o /usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_init/deps/v8/src/setup-isolate-full.o ../deps/v8/src/setup-isolate-full.cc In file included from ../deps/v8/src/setup-isolate-full.cc:7: In file included from ../deps/v8/src/base/logging.h:8: In file included from /usr/include/c++/v1/cstring:59: /usr/include/c++/v1/__config:122:2: error: "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. use _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR instead #error "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. \ ^ c++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.8"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I../deps/v8 -pthread -Wall -Wextra -Wno-unused-parameter -m64 -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 -fno-strict-aliasing -I/usr/local/include -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /usr/ports/editors/atom/work/node-v10.2.1/out/Release/.deps//usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_libbase/deps/v8/src/base/bits.o.d.raw -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -c -o /usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_libbase/deps/v8/src/base/bits.o ../deps/v8/src/base/bits.cc In file included from ../deps/v8/src/base/bits.cc:5: In file included from ../deps/v8/src/base/bits.h:8: In file included from /usr/include/c++/v1/stdint.h:106: /usr/include/c++/v1/__config:122:2: error: "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. use _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR instead #error "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. \ ^ 1 error generated. gmake[3]: *** [deps/v8/gypfiles/v8_libbase.target.mk:131: /usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_libbase/deps/v8/src/base/bits.o] Error 1 gmake[3]: *** Waiting for unfinished jobs.... [...] I have uploaded the full output to https://bsd.to/oh4e It builds fine when I give it --openssl-no-asm, and I also noticed that www/node10 also does exactly this. -- Vidar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3d0282d3-c574-c9dc-a7bb-d0473ebae57e>