From owner-freebsd-perl@FreeBSD.ORG  Mon Oct 14 16:15:59 2013
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: freebsd-perl@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 0590552D
 for <freebsd-perl@freebsd.org>; Mon, 14 Oct 2013 16:15:59 +0000 (UTC)
 (envelope-from mat@FreeBSD.org)
Received: from prod2.absolight.net (mx3.absolight.net
 [IPv6:2a01:678:2:100::25])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id B97CE23DF
 for <freebsd-perl@freebsd.org>; Mon, 14 Oct 2013 16:15:58 +0000 (UTC)
Received: from prod2.absolight.net (localhost [127.0.0.1])
 by prod2.absolight.net (Postfix) with ESMTP id 58CAFBDC5F;
 Mon, 14 Oct 2013 18:15:57 +0200 (CEST)
Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "gw.in.absolight.net",
 Issuer "CA Cert Signing Authority" (not verified))
 by prod2.absolight.net (Postfix) with ESMTPSA id 43B69BDC5E;
 Mon, 14 Oct 2013 18:15:57 +0200 (CEST)
Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239])
 by gw.in.absolight.net (Postfix) with ESMTP id AA35E60E8;
 Mon, 14 Oct 2013 18:15:56 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by ogg.in.absolight.net (Postfix) with ESMTP id 3883B61A196D;
 Mon, 14 Oct 2013 18:15:56 +0200 (CEST)
Date: Mon, 14 Oct 2013 18:15:56 +0200
From: Mathieu Arnold <mat@FreeBSD.org>
To: Olivier Duchateau <duchateau.olivier@gmail.com>, freebsd-perl@freebsd.org
Subject: Re: [REVIEW] Add support of STAGEDIR in x11/xfce4-conf
Message-ID: <57761A213316F6876374E097@ogg.in.absolight.net>
In-Reply-To: <CAHcdu2qKt--P_FcsLmuQ9rOgcKzjXuJXepYJ=d3FqycCSh8xHw@mail.gmail.com>
References: <CAHcdu2qKt--P_FcsLmuQ9rOgcKzjXuJXepYJ=d3FqycCSh8xHw@mail.gmail.com>
X-Mailer: Mulberry/4.0.8 (Mac OS X)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: maintainer of a number of perl-related ports
 <freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
 <mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Oct 2013 16:15:59 -0000

+--On 12 octobre 2013 22:44:18 +0200 Olivier Duchateau
<duchateau.olivier@gmail.com> wrote:
| Hi,
| 
| I'm working to convert Xfce ports to STAGEDIR, and x11/xfce4-conf uses
| Perl (it provides bindings).
| 
| As I'm not familiar with it, I wonder if someone can review my patch [1].

It looks good, with one exception, the perllocal.pod.gz one, I know it'll
show as a leftover, but it should not be in this port's plist, it's ok to
leave it around in the stage directory and not to install it.

Regards,

-- 
Mathieu Arnold