From owner-freebsd-ports-bugs@freebsd.org Sun Apr 1 10:44:28 2018 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39A90F8154F for ; Sun, 1 Apr 2018 10:44:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CAD1F83427 for ; Sun, 1 Apr 2018 10:44:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 1996E27787 for ; Sun, 1 Apr 2018 10:44:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w31AiQIr029161 for ; Sun, 1 Apr 2018 10:44:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w31AiQkU029160 for freebsd-ports-bugs@FreeBSD.org; Sun, 1 Apr 2018 10:44:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 227155] [NEW PORT] databases/py-carbonate: Tools for managing federated carbon clusters Date: Sun, 01 Apr 2018 10:44:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2018 10:44:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227155 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #5 from Kubilay Kocak --- A few review items: /usr/local should never be hardcoded. In this case, since we cant pass it a= s a configuration to the build, use %%PREFIX%% in the patch, and then use REINPLACE_CMD to replace it with the current ${PREFIX} value at post-patch.= [1] Either add a comment above the commented out LICENSE_FILE to explain it ('n= ot yet packaged with distfile'), or leave the line out. Without a comment it l= ooks accidental. Since the python package installs console scripts (things into localbase/bi= n) [2], make the port concurrent versions safe by using USE_PYTHON=3Dconcurren= t, which will automatically version suffix all scripts and create (version-les= s) symlinks to point the versioned scriptnames. This isn't a major issue as the port currently only supports 2.7, but the port should be made concurrent sa= fe anyway. Add comments to patches, in particular for ones that aren't self explanator= y. In this case the patch that adds 'ROUTER_HASH_TYPE =3D None'. You (awesomel= y) explained (most?) of them in your initial comment 0, add those comments and references to the top of all the patches themselves. [1] See: 4.4.3. Simple Automatic Replacements in Porters Handbook [2] https://github.com/graphite-project/carbonate/blob/master/setup.py#L37 --=20 You are receiving this mail because: You are the assignee for the bug.=