From owner-svn-src-head@FreeBSD.ORG Tue Jul 8 14:58:54 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 11A0EBAA for ; Tue, 8 Jul 2014 14:58:54 +0000 (UTC) Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com [209.85.223.174]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CA6832C84 for ; Tue, 8 Jul 2014 14:58:53 +0000 (UTC) Received: by mail-ie0-f174.google.com with SMTP id rd18so5101112iec.19 for ; Tue, 08 Jul 2014 07:58:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=AX5pXHegZe19clXIjwYMo7wAspJ9YRT55HzV4Sp6qGI=; b=HRva60pNsnKCeUMuHu2pkKYUEyfbvF8Cy7oqAn/QlJVTmyidvGyuOG3qfkU8O/rw49 uyFL5nS4JFWZ+gfgkO3KObEQ3qM2YFyBbiVQ3V8saEfx+DFOVXWr8CcbEq03+6mpwNPK VkVxfBXh1HkEHDUcSrVaMSj+80f88QI8KFgdgZ2FoPQ4SduwKEdzNiJxDPojvl4c4Aru RiR/HVpuwxySk3bkE3q/xvi1BNeCjlgi4Z+/m54oX5QGmMtBVM2mkMJB1Pn5Fqiewc7W fatsXhA8cfIqjEuXav5k0cYQE92VEdlqqBf53ixmFAzBysDxKnrAP9N4P9vCY8dEKEgb naPQ== X-Gm-Message-State: ALoCoQlZkMi2KjeN6D1dvOOZf4b0rh/vm1HFDl/l3CNcC+xcWy92wfXcIdsLZtQJ9qOhBKZ294Uh X-Received: by 10.43.78.19 with SMTP id zk19mr3397747icb.77.1404831527597; Tue, 08 Jul 2014 07:58:47 -0700 (PDT) Received: from bsdimp.bsdimp.com (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id j10sm6093519igv.17.2014.07.08.07.58.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 08 Jul 2014 07:58:47 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r268376 - head/bin/rm From: Warner Losh In-Reply-To: <53BB9911.60804@freebsd.org> Date: Tue, 8 Jul 2014 08:58:45 -0600 Message-Id: <37C52A06-1FBA-4750-A6CC-F89B0347BED3@bsdimp.com> References: <201407072321.s67NLL7p070713@svn.freebsd.org> <53BB9911.60804@freebsd.org> To: Julian Elischer X-Mailer: Apple Mail (2.1878.6) Cc: svn-src-head@freebsd.org, Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jul 2014 14:58:54 -0000 --Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jul 8, 2014, at 1:09 AM, Julian Elischer wrote: > On 7/8/14, 7:21 AM, Warner Losh wrote: >> Author: imp >> Date: Mon Jul 7 23:21:20 2014 >> New Revision: 268376 >> URL: http://svnweb.freebsd.org/changeset/base/268376 >>=20 >> Log: >> rm -rf can fail sometimes with an error from fts_read. Make it = honor >> fflag to ignore fts_read errors, but stop deleting from that = directory >> because no further progress can be made. >> When building a kernel with a high -j value on a high core count >> machine, during the cleanobj phase we can wind up doing multiple rm >> -rf at the same time for modules that have subdirectories. This >> exposed this race (sometimes) as fts_read can return an error if = the >> directory is removed by another rm -rf. Since the intent of the -f >> flag was to ignore errors, even if this was a bug in fts_read, we >> should ignore the error like we've been instructed to do. > One could make an argument that being unable to delete something = because someone else deleted it first is a "non error". > Even without -f rm is supposed to return an error when you try to delete something that = isn=92t there. Do you have a standards quote handy? Warner --Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTvAclAAoJEGwc0Sh9sBEAaxcP/0aq+6Hq7+88cTprWH4RHfWM dx6jB0DtpA/8lzCNiKCW5UVOegvOtRNHmZlIyng+wo6XTXz4M5ETsAImdcvGcuA9 TnobVBtW0cGSudBdxTw+uPxDyGN3GCSSVxAj9i05914p/1efhWW9Udhzagz69PiI 0qShIUL2vITNzQs9CUbeS4omLFwH5eiOxrPb1swgDefssRxLeaUmvQrQJOTNCs3E y2KXC3+v7Efd8LWEQKVEtj7oTG3IlCOLdOeO3Sq5vy8lIvDIAlZz3b/kr24lJ3KW dWQzG+eI2vTi/CN+Gmyu1Yqj8jAJavGf+IJjMF+gjCXiQbmOkuYWx2wzuuRIXjvp tKEQW2SAOp81J7OjABBSvDr2ZQdFMp+KrXqouCgBZYpQgaP423J/c9NAEvlbLBPU AWsrqOCuwUluaRtm+s5zI4+G1F3auo+UZV+xJw0itnQvkQUG3eHUgxc/j6iXAua8 eLPtPgeaHQxLk7EPO4xIDYU5w76aZ7pyvwT+fss3kJdb69c5mliGoHgL1JBLh0VX k0Fyhk1HVVmbQoPgddHC65jRFRLpvUEg5eSsNe+T5wHnaV7fSQ/y4o0q0lEDljYz qHVYLEUPKYi5E1Mr8FFyL7n6pj46HKzIAMeJRa0s66A131ckgbMv02y43qNWSijp GtfqCu6IFzoYks1aHbiT =utBI -----END PGP SIGNATURE----- --Apple-Mail=_33D144FF-CB14-4772-B6B1-27DC415B46F5--