From owner-freebsd-sparc64@FreeBSD.ORG  Mon Jul  7 15:10:36 2003
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2E6D537B401
	for <sparc64@freebsd.org>; Mon,  7 Jul 2003 15:10:36 -0700 (PDT)
Received: from slagheap.net (slagheap.net [208.36.163.156])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9A56A43FAF
	for <sparc64@freebsd.org>; Mon,  7 Jul 2003 15:10:31 -0700 (PDT)
	(envelope-from peter@alphafight.net)
Received: from alphafight.net (phoenix [208.36.163.156])
	by slagheap.net (8.12.9/8.12.9) with ESMTP id h67MAUBo022346;
	Mon, 7 Jul 2003 15:10:30 -0700 (PDT)
Date: Mon, 7 Jul 2003 15:10:09 -0700
Content-Type: text/plain; delsp=yes; charset=US-ASCII; format=flowed
Mime-Version: 1.0 (Apple Message framework v552)
To: John-Mark Gurney <gurney_j@efn.org>
From: peter bartoli <peter@alphafight.net>
In-Reply-To: <20030707220207.GI44762@funkthat.com>
Message-Id: <C59A7969-B0C7-11D7-BE31-000393D16F58@alphafight.net>
Content-Transfer-Encoding: 7bit
X-Mailer: Apple Mail (2.552)
cc: sparc64@freebsd.org
Subject: Re: bug in port security/nbaudit ...
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2003 22:10:36 -0000


On Monday, July 7, 2003, at 03:02  PM, John-Mark Gurney wrote:
> Inform the nbaudit author that he is not using a proper data type to
> represent an ip address.  He is probably using u_long instead of  
> in-addr_t
> (aka uint32_t).  (This doesn't show up since the alpha is little endian
> and luckily sticks the "ip" in the proper place.)

You are correct; looking over the code, he is using u_long ...

> His program is broken on all LP64 big endian platforms.

... however nbaudit (AKA nat) is one of those that's still useful, but  
hasn't been updated by the original author since release.  Problems  
since have been fixed with patches, at least in the OpenBSD ports tree  
... I can see no patches in the FreeBSD port.

Is this better referred to ports@freebsd.org or to the "whom" in the  
port Makefile?

# Date created:                   Mon Feb 03, 1997
# Whom:                           David O'Brien (obrien@NUXI.com)

________________________________________________________________________ 
____

Peter Bartoli, CTO                                              PO Box  
12714
Alphafight Heavy Industries                          San Diego CA  
92112-3714
http://www.alphafight.net                voice 619.702.1071 fax  
619.702.9237
________________________________________________________________________ 
____