From nobody Mon Sep 22 06:07:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cVXj75406z68fbt; Mon, 22 Sep 2025 06:08:11 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4cVXj71X7nz3bwf; Mon, 22 Sep 2025 06:08:11 +0000 (UTC) (envelope-from herbert@gojira.at) Authentication-Results: mx1.freebsd.org; none Received: from smtp202.mailbox.org (smtp202.mailbox.org [IPv6:2001:67c:2050:b231:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4cVXhc1ddfz9sc4; Mon, 22 Sep 2025 08:07:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gojira.at; s=MBO0001; t=1758521264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4gh/CdPMb6D7jg9++0rGtaj/44WBMZhxIOwa6x4kZLo=; b=UZM+7ctqw/w6oi9p/JvujGRgThrfsK8r+kVfM4eGm+Kot5ITKXFPxPdqpJjlSeeA4ldhOV wFQJ1Cwi108P8Ecp5+xm7ultKqQBiPgQ+DFUc4zp2JXlD1BOcAme5gwXIBXgsVg9Jr4eFE dUbinFu+fY31hRLfRU1eVsc3E3vE0237t3BRaKMKdBJ3CiFgdZMcfJs/TnGdmiEcVQgTCv TvxHqljYtO2MtKGmExAZUPTSBcQIftX2ZFE0bXmx0BIdRwTgjhWKhtwavMZoEVlfS4bDot 451/ETtMbYhpDsUmX6gclTy577NNa2hR1Pqpc1SO114d0/tLjpscgdCAeUSZ4A== Date: Mon, 22 Sep 2025 08:07:08 +0200 Message-ID: <87plbj9g1f.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: Guido Falsi Cc: Gleb Smirnoff , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 31ec8b6407fd - main - sys/netinet6: Implement RFC 7217 In-Reply-To: <63c07846-cd1b-4ff2-8c35-c0a6db6954cc@FreeBSD.org> References: <202509201231.58KCVqBC047480@gitrepo.freebsd.org> <874iswhip4.wl-herbert@gojira.at> <07503de1-785e-4e4d-b4e4-0524aeb064e1@FreeBSD.org> <87jz1sc9fr.wl-herbert@gojira.at> <31da7dd5-ae67-4fb4-aa47-81e57f460c9d@FreeBSD.org> <909b3e33-0639-4abc-915f-073cd0f304da@FreeBSD.org> <63c07846-cd1b-4ff2-8c35-c0a6db6954cc@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cVXj71X7nz3bwf On Mon, 22 Sep 2025 02:26:12 +0200, Guido Falsi wrote: > > On 9/22/25 01:00, Gleb Smirnoff wrote: > > On Sun, Sep 21, 2025 at 09:17:15PM +0200, Guido Falsi wrote: > > G> > Is struct nd_ifinfo something that is used as argument to ioctl(2)? > > G> > If so, then adding counter_u64_t into it is not correct. > > G> > > > G> > I would suggest to not revert the change as a whole, but remove the > > G> > counter only and bring struct nd_ifinfo back to original. The counter > > G> > should probably go into struct in6_ifextra that is pointed by > > G> > if->if_afdata[AF_INET6]. > > G> > > G> Thanks for the feedback and suggestion! > > G> > > G> You are definitely right! I'm in the process to create a review for such a > > G> change shortly, I'll post it as soon as I'm able to have the code tested. > > > > As long as Herbert confirms that the patch fixes the issue for him, please > > consider the change as approved by an src committer and please push it. We > > want to enter the stabweek that starts tomorrow without a ABI breakage. > > > > @Herbert I'm attaching a patch against base sources for you to test. > > It moves the new counter to in6_ifextra structure, removing the ABI > breakage I introduced. Everything should be back to working with this. > > Can you confirm it fixes the issue for you? Thanks a lot, this patch fixes the issue.