From owner-freebsd-net@FreeBSD.ORG Mon Feb 9 00:04:13 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B83E58CC for ; Mon, 9 Feb 2015 00:04:13 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 97807F17 for ; Mon, 9 Feb 2015 00:04:13 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1904DEX041085 for ; Mon, 9 Feb 2015 00:04:13 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1904D2W041084; Mon, 9 Feb 2015 00:04:13 GMT (envelope-from root) Date: Mon, 9 Feb 2015 00:04:13 +0000 To: freebsd-net@freebsd.org From: "davide (Davide Italiano)" Subject: [Differential] [Updated, 12 lines] D1805: [sockbuf] Don't access fields directly, use accessor functions Message-ID: <392d01c0d7111c7fadaacd9d2e1db1cd@localhost.localdomain> X-Priority: 3 Thread-Topic: D1805: [sockbuf] Don't access fields directly, use accessor functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OWRjZTdmYWI1ODk3ZGNkOWIxYTAyYWM0MjY5IFTX+X0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2015 00:04:13 -0000 davide updated this revision to Diff 3698. davide added a comment. Updated removing the last place where this was used. I was not certain about it before so I previously left it as-is, but it looks like in this case order doesn't matter considering we're holding the socket buffer lock across the two calls. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1805?vs=3695&id=3698 REVISION DETAIL https://reviews.freebsd.org/D1805 AFFECTED FILES sys/kern/uipc_socket.c To: davide, kmacy, np, lstewart, rrs, rwatson Cc: freebsd-net