Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 9 Apr 2017 21:54:58 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Mark Felder <feld@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r438115 - head/security/bearssl
Message-ID:  <20170409195458.kfaedrx6kenkqnq3@ivaldir.net>
In-Reply-To: <20170409194648.pie7o7zxffaoww74@ivaldir.net>
References:  <201704091926.v39JQS2q099605@repo.freebsd.org> <20170409194017.iuzw72mcompsy5l4@ivaldir.net> <20170409194648.pie7o7zxffaoww74@ivaldir.net>

next in thread | previous in thread | raw e-mail | index | archive | help

--ui6qjisxkf5trvt6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 09, 2017 at 09:46:48PM +0200, Baptiste Daroussin wrote:
> On Sun, Apr 09, 2017 at 09:40:17PM +0200, Baptiste Daroussin wrote:
> > On Sun, Apr 09, 2017 at 07:26:28PM +0000, Mark Felder wrote:
> > > Author: feld
> > > Date: Sun Apr  9 19:26:28 2017
> > > New Revision: 438115
> > > URL: https://svnweb.freebsd.org/changeset/ports/438115
> > >=20
> > > Log:
> > >   security/bearssl: Update to 0.4
> > >  =20
> > >   Now requires GCC. The Clang build is not functional as it fails to =
link.
> > >   The cause is under investigation.
> > >=20
> > > Modified:
> > >   head/security/bearssl/Makefile
> > >   head/security/bearssl/distinfo
> > >   head/security/bearssl/pkg-plist
> > >=20
> > > Modified: head/security/bearssl/Makefile
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > > --- head/security/bearssl/Makefile	Sun Apr  9 18:29:32 2017	(r438114)
> > > +++ head/security/bearssl/Makefile	Sun Apr  9 19:26:28 2017	(r438115)
> > > @@ -2,8 +2,8 @@
> > >  # $FreeBSD$
> > > =20
> > >  PORTNAME=3D	bearssl
> > > -PORTVERSION=3D	0.2
> > > -PORTREVISION=3D	1
> > > +PORTVERSION=3D	0.4
> > > +PORTREVISION=3D	0
> > >  CATEGORIES=3D	security devel
> > >  MASTER_SITES=3D	https://bearssl.org/
> > > =20
> > > @@ -12,14 +12,12 @@ COMMENT=3D	Implementation of TLS/SSL in C
> > > =20
> > >  LICENSE=3D	MIT
> > > =20
> > > -USES=3D		compiler:c11
> > > -
> > > -post-patch:
> > > -	${REINPLACE_CMD} 's|CC =3D gcc|CC ?=3D gcc|' ${WRKSRC}/Makefile
> > > +USES=3D		compiler
>=20
> There is no point in leaving that
> > > +USE_GCC=3D	yes
> > > =20
> > >  do-install:
> > > -	${INSTALL_PROGRAM} ${WRKSRC}/brssl ${STAGEDIR}${LOCALBASE}/bin/
> > > -	(cd ${WRKSRC}/inc && ${COPYTREE_SHARE} . ${STAGEDIR}${LOCALBASE}/in=
clude/)
> > > -	${INSTALL_DATA} ${WRKSRC}/libbearssl.a ${STAGEDIR}${LOCALBASE}/lib/
> > > +	${INSTALL_PROGRAM} ${WRKSRC}/build/brssl ${STAGEDIR}${LOCALBASE}/bi=
n/
> > > +	${INSTALL_DATA} ${WRKSRC}/build/libbearssl.so ${STAGEDIR}${LOCALBAS=
E}/lib/
>=20
> Should be INSTALL_LIB
>=20
> > > +	(cd ${WRKSRC}/inc && ${COPYTREE_SHARE} \* ${STAGEDIR}${LOCALBASE}/i=
nclude)
> > > =20


https://people.freebsd.org/~bapt/bearssl.diff this builds fine for me

I don't know why you added compiler:c11 before but given I have no gcc 4.2
available I cannot test without it so I kept it

if you pass variables with args there is no need to replace VAR =3D by VAR =
?=3D in
makefiles.

tested in 10.3, 11 and current

Bapt


--ui6qjisxkf5trvt6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAljqkZIACgkQY4mL3PG3
PlqCGRAAm9av37usI1BK/9UF0IfSpCjJxzs5Ueaaf8ZgeMSqEIVbWzT6rz6vB9gV
l0cbRSsy8f9a7BqmzzwmX2u15BwgaPeoZxPM2xXdIJ99M1V4qgxhAU1IEbujSf0K
rNDmZ4Xw6KUnQxk+NPU5gv6BcAfqrBNHiC9cXW2Ei4xgKks2IRkSWt+YaX5dqpUk
sI8bVM9SJDv6/KqFgnPf0H3Luca0btQma3VtoiQeaAsDtZBLD5UZrybYYm39Zu9A
0SeQf0sk4btj89xvljtIA4ylJfsrlYJIsd97PiuZ30HplZloFVE7ALCsuTWw9sZ1
2Xl1ywDQn+MighFS7v5W62bB4YSNnBkC5qR53OicQpX5I/pDmMnQgD73yf9KFnR2
3NtXt7c2LizQVoTc+m54DZ4KSsMXPlPEhNyMvgoPGvQtPE+tRzyq7e7f7KNwnHL3
xDLqEf+M3Ho974qVXMl6Y4La0wtpq+nEehitYz642dbFy49YjvFDn3V5QGj3QUpq
FNRH31B7yHf/xxKovTZTZSp64NY6e2tyOAhibKd9YfsY2k2eVk7/h6pGueH6Dnzw
Jpn/Gi+Dw1Nz3dXh/euFTFMyWEo/fUki7jTGXbfQDdI1w5vhVArgV853L88wonc4
JWJV9B80ckiu02oP7/oOagghqGy/7MxImhkMPbfW2D7XQgiBiWc=
=+iwc
-----END PGP SIGNATURE-----

--ui6qjisxkf5trvt6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170409195458.kfaedrx6kenkqnq3>