Date: Sun, 3 Apr 2016 16:25:51 +0000 (UTC) From: "Pedro F. Giffuni" <pfg@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r297526 - head/sys/geom/sched Message-ID: <201604031625.u33GPpnK088911@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: pfg Date: Sun Apr 3 16:25:51 2016 New Revision: 297526 URL: https://svnweb.freebsd.org/changeset/base/297526 Log: g_sched_destroy(): prevent return of uninitialized scalar variable. For the !gsp case there some chance of returning an uninitialized return value. Prevent that from happening by initializing the error value. CID: 1006421 Modified: head/sys/geom/sched/g_sched.c Modified: head/sys/geom/sched/g_sched.c ============================================================================== --- head/sys/geom/sched/g_sched.c Sun Apr 3 14:40:54 2016 (r297525) +++ head/sys/geom/sched/g_sched.c Sun Apr 3 16:25:51 2016 (r297526) @@ -1316,7 +1316,8 @@ g_sched_destroy(struct g_geom *gp, boole gsp->gs_fini(sc->sc_data); g_gsched_unref(gsp); sc->sc_gsched = NULL; - } + } else + error = 0; if ((sc->sc_flags & G_SCHED_PROXYING) && oldpp) { error = g_destroy_proxy(gp, oldpp);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604031625.u33GPpnK088911>