From owner-p4-projects@FreeBSD.ORG Mon May 17 10:41:22 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 0D4201065673; Mon, 17 May 2010 10:41:22 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5FEC106566C for ; Mon, 17 May 2010 10:41:21 +0000 (UTC) (envelope-from zec@fer.hr) Received: from repoman.freebsd.org (unknown [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B459E8FC12 for ; Mon, 17 May 2010 10:41:21 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id o4HAfLlG000118 for ; Mon, 17 May 2010 10:41:21 GMT (envelope-from zec@fer.hr) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id o4HAfLiW000116 for perforce@freebsd.org; Mon, 17 May 2010 10:41:21 GMT (envelope-from zec@fer.hr) Date: Mon, 17 May 2010 10:41:21 GMT Message-Id: <201005171041.o4HAfLiW000116@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to zec@fer.hr using -f From: Marko Zec To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 178384 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 10:41:22 -0000 http://p4web.freebsd.org/@@178384?ac=10 Change 178384 by zec@zec_nxlab on 2010/05/17 10:40:26 By looking at the original ip_mroute_modevent(), it seems that X_ip_mrouter_done() should be called in from vnet_mroute_uninit() just in case, even as it should be already automatically invoked at the time V_ip_mroute socket gets closed. NB vnet_mroute_uninit() can never be invoked until V_ip_mroute is closed, so this seems redundant to me, but we keep it to remain 100% compatible with nooptions VIMAGE builds. Affected files ... .. //depot/projects/vimage/src/sys/netinet/ip_mroute.c#36 edit Differences ... ==== //depot/projects/vimage/src/sys/netinet/ip_mroute.c#36 (text+ko) ==== @@ -2837,6 +2837,7 @@ vnet_mroute_uninit(const void *unused __unused) { + X_ip_mrouter_done(); FREE(V_nexpire, M_MRTABLE); V_nexpire = NULL; }