From nobody Sat Feb 22 19:29:06 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z0cW76l08z5pFp1 for ; Sat, 22 Feb 2025 19:29:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z0cW75bYZz3mTp for ; Sat, 22 Feb 2025 19:29:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740252547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1XlfeNu5qoTdNusWwtOZwWnQ/M4dwYC48lrp5M5IQ7U=; b=t9kdf8yUEqb4UJOzZVDAt53uIRTkTBl2DhgghJLBSfc0V4ZJ8QkZ4jgpqCQLNFZ+GTRbmm ZjmcgewLNstyChhUyEBTQhq23AbNGTvxMtrRAkuMbH54bn2NKnOKwbzdUVKV0NcY1qIF3g bzym26jLEZN4Ot+PNezQ+JgVSxysA4IyU1/QCa33kbvf01+JXUfLP69fGwKZOGijkEZXv4 myWgkk0EvA9Ii/MmcE5HB2knznCZhezp5CXHc5w7Mhqo7DdbB7g+XNlJZwA/EOvtNpwL0d H/4KvLOxpOtuKtH3cU/Y3ImWoQFCy9Msci7F71A6NKidIrAxqNiP4nNBuUYNqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740252547; a=rsa-sha256; cv=none; b=dninb1stIX6q4mPtuwyUucQSp/b5eOjFGFzwHgAXfH1vCtBpAQdkFkrrHaA8bLWEAxAxCc 3fEWoKbLuvrodBpI2XHCBrKt+EU3uDEhABo3l2itXI2CLleHFqw03m9Mm2sF0u4liP4iUu 52sBlKgZEGi2a9lUbmiel/7p9i1Svunfveedp+W37/XPGCLq73M9GLlZm10gGCVabrH5K7 lf84u6MCUg7yr2BIjTsLpsSTy9LZ8jOIFRlt3RyyfF7YoG8m7xEigFJQ97Q28P9ATBt2sN OCIhSSIke53FoYGbC9stmu8kEwb8GSeWKKE6YkiH/HX1RGd7FAtQgY5Vnf7eYA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740252547; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1XlfeNu5qoTdNusWwtOZwWnQ/M4dwYC48lrp5M5IQ7U=; b=ZpvFm14g0NxatMpT5TJSEclzUuww2DrBAl3C3J0826xiQrCeYDVVFpEtJPnBILdTLu9aK3 znRVDOPZ2zXkuInSvAYVpyGA7ysfxUVov5JNjHT1/q7yC2rjCzpM5AFZLX/wRBoOqxTdI3 0gBRkaXfW1sVT7B/UfXKqDzN0WZC47rU1Na2MsEbkbzC/n3IBydqeOMjjhD4yeO61ujurD bfv/Z2JSAEs359Ig0Qxsoz8P2AN13umSgR85fg+X7QwVVK8ZStWAnqr3IIIAGVUrdDNiuT xCrGGg9cHTtrjcesgzMObmi98Y/gDN1oTLRcB8g4s2Vr1JVWWVEAj7dsedE7+g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Z0cW70J1Gz6Cw for ; Sat, 22 Feb 2025 19:29:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 51MJT6Qn095326 for ; Sat, 22 Feb 2025 19:29:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 51MJT6Ei095325 for net@FreeBSD.org; Sat, 22 Feb 2025 19:29:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 284872] [carp] Missing byte order correction causing certain unicast announcements to have invalid destination MAC address Date: Sat, 22 Feb 2025 19:29:06 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable14? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D284872 --- Comment #5 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D93fbdef51a13b8facac3633f55804a59c= a27f635 commit 93fbdef51a13b8facac3633f55804a59ca27f635 Author: Zhenlei Huang AuthorDate: 2025-02-22 19:26:32 +0000 Commit: Zhenlei Huang CommitDate: 2025-02-22 19:26:32 +0000 tests: carp: Update test case unicast_v4 to catch PR 284872 In the current test case unicast_v4, host one acts as a router, but it uses if_bridge(4) to verify the reachability to CARP master. Unfortunately, if_bridge(4) brings the two CARP hosts into the same broadcast domain, thus with an unusual (undocumented) setup, one host is in unicast mode but another one in multicast, or two hosts are both in multicast mode, the test case can falsely report success. Fix that by propagating route via routed(8). PR 284872 shows that CARP(4) happens to send packets with multicast destination when the unicast peer address is in the range x.x.x.224 ~ x.x.x.239. Update the peer address in test case to catch that bug. PR: 284872 Reviewed by: kp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D49076 tests/sys/netinet/carp.sh | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=