From owner-freebsd-infiniband@freebsd.org Sat Aug 8 05:42:45 2015 Return-Path: Delivered-To: freebsd-infiniband@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E06EE9B6DC3 for ; Sat, 8 Aug 2015 05:42:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E962D47; Sat, 8 Aug 2015 05:42:45 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by qkdv3 with SMTP id v3so43828131qkd.3; Fri, 07 Aug 2015 22:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=rbTGaAEVT0g2D2HySbpeKqfkx9vmxTOl7QEoSEKARug=; b=MQiK+DRMnXAm+ZHcGXFdb9no5Fi8IRDS/4o+5n/ulJlnuVp+5o9oGaui3v7+4/cfBo inDGpfuTdi2xBfVnUz1MBwAL8YQGvOrWIgp9S3BhNBVWIyhaukWa20vntjOO8eh4kjj+ H/MgelPHDfHL8VX+xilI0KcITc0mqziNQPgpuy5fKejE5siRjnzOXLXbCUfajNuJUnOr EXZCFOmyUR9uL010eVVRYjDLWWbWm38Jilo2gu9gqGCJtydgiRa3g5tFMoeWYjj36xrp Nd8hO/Bw0ogE9O/Rje7Lmdo3lS78RUNXVxkEbeK0fGxc1GXnjp+Zir1371qE8Bj9yqlP jyOQ== MIME-Version: 1.0 X-Received: by 10.55.31.96 with SMTP id f93mr20387070qkf.5.1439012564665; Fri, 07 Aug 2015 22:42:44 -0700 (PDT) Received: by 10.140.98.73 with HTTP; Fri, 7 Aug 2015 22:42:44 -0700 (PDT) In-Reply-To: <20150807192930.GA88925@muskytusk> References: <30977F3A-59D1-4CA4-BCF6-9062A04CFF44@gmail.com> <20150807192930.GA88925@muskytusk> Date: Fri, 7 Aug 2015 22:42:44 -0700 Message-ID: Subject: Re: Enable OFED/Infiniband support in 11.0-RELEASE by default? From: NGie Cooper To: Mark Johnston Cc: freebsd-infiniband@freebsd.org, Benno Rice , Hans Petter Selasky , Jeff Roberson Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-infiniband@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Infiniband on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2015 05:42:46 -0000 On Fri, Aug 7, 2015 at 12:29 PM, Mark Johnston wrote: > On Fri, Aug 07, 2015 at 11:32:00AM -0700, Garrett Cooper wrote: >> Hi, >> One of the complaints from engineers at Isilon I=E2=80=99ve receiv= ed in the past is that Infiniband/OFED stack support isn=E2=80=99t enabled = by default in GENERIC. I would like to enable it by default in GENERIC to i= mprove test coverage by a general audience and ensure that bugs introduced = elsewhere (build bugs, network interface, kernel interface bugs) aren=E2=80= =99t ignored by accident when running make tinderbox builds as it=E2=80=99s= not built by default. > > make tinderbox will build LINT kernels, which for amd64 will include the > OFED stack. > > As Jason pointed out, all of the IB stack (including the Linux compat > shims) can already be built as a KLD. Why not just make WITH_OFED the > default on amd64 instead? That way the KLDs and userland tools will be > built by default, and the size of the kernel needn't grow. There are a few issues with just doing WITH_OFED, instead of building both the sys/ofed and contrib/ofed separately: 1. sys/ofed by itself isn't incredibly useful (as we've seen internally). Yes, not building opensm can be done if you're running it on an IB switch, but the diagnostic tools are pretty helpful.. 2. contrib/ofed has seen its fair share of bugs in the past compilation wise (either due to interfaces or general header compilation issues). I'd rather nip these in the bud ASAP instead of delay them. 3. Building it just on amd64 might disguise issues with endianness, 64-bit issues, etc. Again, I want opensm, etc to be as useful on all platforms, if possible. Thanks! -NGie