From nobody Sat Nov 20 19:26:03 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E28A81898256; Sat, 20 Nov 2021 19:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HxNmq5gPkz3J96; Sat, 20 Nov 2021 19:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A2E1421A82; Sat, 20 Nov 2021 19:26:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1AKJQ39W043871; Sat, 20 Nov 2021 19:26:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1AKJQ32F043870; Sat, 20 Nov 2021 19:26:03 GMT (envelope-from git) Date: Sat, 20 Nov 2021 19:26:03 GMT Message-Id: <202111201926.1AKJQ32F043870@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Robert Wing Subject: git: 8981a100e614 - main - mount: retire kernel_vmount() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rew X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8981a100e614d9030eb75e7e828caad48214306d Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rew: URL: https://cgit.FreeBSD.org/src/commit/?id=8981a100e614d9030eb75e7e828caad48214306d commit 8981a100e614d9030eb75e7e828caad48214306d Author: Robert Wing AuthorDate: 2021-11-20 19:22:28 +0000 Commit: Robert Wing CommitDate: 2021-11-20 19:22:28 +0000 mount: retire kernel_vmount() The last usage of this function was removed in e3b1c847a4237ad9. There are no in-tree consumers of kernel_vmount(). Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D32607 --- ObsoleteFiles.inc | 3 +++ share/man/man9/Makefile | 1 - share/man/man9/kernel_mount.9 | 25 +------------------------ sys/kern/vfs_mount.c | 26 -------------------------- sys/sys/mount.h | 1 - 5 files changed, 4 insertions(+), 52 deletions(-) diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc index 00cfe2a33129..9bfd496e334b 100644 --- a/ObsoleteFiles.inc +++ b/ObsoleteFiles.inc @@ -40,6 +40,9 @@ # xargs -n1 | sort | uniq -d; # done +# 20211120 +OLD_FILES+=usr/share/man/man9/kernel_vmount.9.gz + # 20211115: vm_page busy functions removed OLD_FILES+=share/man/man9/vm_page_sbusy.9.gz OLD_FILES+=share/man/man9/vm_page_xbusy.9.gz diff --git a/share/man/man9/Makefile b/share/man/man9/Makefile index 2bb45e3a6dc8..150b7b5715c0 100644 --- a/share/man/man9/Makefile +++ b/share/man/man9/Makefile @@ -1313,7 +1313,6 @@ MLINKS+=ithread.9 ithread_add_handler.9 \ ithread.9 ithread_schedule.9 MLINKS+=kernacc.9 useracc.9 MLINKS+=kernel_mount.9 free_mntarg.9 \ - kernel_mount.9 kernel_vmount.9 \ kernel_mount.9 mount_arg.9 \ kernel_mount.9 mount_argb.9 \ kernel_mount.9 mount_argf.9 \ diff --git a/share/man/man9/kernel_mount.9 b/share/man/man9/kernel_mount.9 index 873f522fa1f7..7a11007c288b 100644 --- a/share/man/man9/kernel_mount.9 +++ b/share/man/man9/kernel_mount.9 @@ -25,13 +25,12 @@ .\" .\" $FreeBSD$ .\" -.Dd December 13, 2004 +.Dd November 20, 2021 .Dt KERNEL_MOUNT 9 .Os .Sh NAME .Nm free_mntarg , .Nm kernel_mount , -.Nm kernel_vmount , .Nm mount_arg , .Nm mount_argb , .Nm mount_argf , @@ -42,8 +41,6 @@ .Fn free_mntarg "struct mntarg *ma" .Ft int .Fn kernel_mount "struct mntarg *ma" "int flags" -.Ft int -.Fn kernel_vmount "int flags" ... .Ft "struct mntarg *" .Fo mount_arg .Fa "struct mntarg *ma" "const char *name" "const void *val" "int len" @@ -100,12 +97,6 @@ that code will be called and the file system mount will not be attempted. .Pp The -.Fn kernel_vmount -is a function similar to -.Xr printf 9 -which is used to mount a file system. -.Pp -The .Fn mount_arg function takes a plain argument and crafts parts of the structure with regards to various mount options. @@ -178,20 +169,6 @@ msdosfs_cmount(struct mntarg *ma, void *data, int flags, struct thread *td) return (error); } .Ed -.Pp -When working with -.Fn kernel_vmount , -.Fa varargs -must come in pairs, e.g., -.Brq Va name , value . -.Bd -literal - error = kernel_vmount( - MNT_RDONLY, - "fstype", vfsname, - "fspath", "/", - "from", path, - NULL); -.Ed .Sh SEE ALSO .Xr VFS 9 , .Xr VFS_MOUNT 9 diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c index 5b68a8fec474..07076bc2f4f7 100644 --- a/sys/kern/vfs_mount.c +++ b/sys/kern/vfs_mount.c @@ -2816,32 +2816,6 @@ kernel_mount(struct mntarg *ma, uint64_t flags) return (error); } -/* - * A printflike function to mount a filesystem. - */ -int -kernel_vmount(int flags, ...) -{ - struct mntarg *ma = NULL; - va_list ap; - const char *cp; - const void *vp; - int error; - - va_start(ap, flags); - for (;;) { - cp = va_arg(ap, const char *); - if (cp == NULL) - break; - vp = va_arg(ap, const void *); - ma = mount_arg(ma, cp, vp, (vp != NULL ? -1 : 0)); - } - va_end(ap); - - error = kernel_mount(ma, flags); - return (error); -} - /* Map from mount options to printable formats. */ static struct mntoptnames optnames[] = { MNTOPT_NAMES diff --git a/sys/sys/mount.h b/sys/sys/mount.h index 68211785b7c5..1863a36738d1 100644 --- a/sys/sys/mount.h +++ b/sys/sys/mount.h @@ -973,7 +973,6 @@ vfs_statfs_t __vfs_statfs; int dounmount(struct mount *, uint64_t, struct thread *); int kernel_mount(struct mntarg *ma, uint64_t flags); -int kernel_vmount(int flags, ...); struct mntarg *mount_arg(struct mntarg *ma, const char *name, const void *val, int len); struct mntarg *mount_argb(struct mntarg *ma, int flag, const char *name); struct mntarg *mount_argf(struct mntarg *ma, const char *name, const char *fmt, ...);