From owner-freebsd-geom@FreeBSD.ORG  Wed Apr 18 05:20:07 2012
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 99399106564A
	for <freebsd-geom@hub.freebsd.org>;
	Wed, 18 Apr 2012 05:20:07 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 852D18FC0C
	for <freebsd-geom@hub.freebsd.org>;
	Wed, 18 Apr 2012 05:20:07 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3I5K7Rj056261
	for <freebsd-geom@freefall.freebsd.org>; Wed, 18 Apr 2012 05:20:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3I5K7IO056260;
	Wed, 18 Apr 2012 05:20:07 GMT (envelope-from gnats)
Date: Wed, 18 Apr 2012 05:20:07 GMT
Message-Id: <201204180520.q3I5K7IO056260@freefall.freebsd.org>
To: freebsd-geom@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: bin/165789: commit references a PR
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Apr 2012 05:20:07 -0000

The following reply was made to PR bin/165789; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/165789: commit references a PR
Date: Wed, 18 Apr 2012 05:16:28 +0000 (UTC)

 Author: ae
 Date: Wed Apr 18 05:16:20 2012
 New Revision: 234411
 URL: http://svn.freebsd.org/changeset/base/234411
 
 Log:
   MFC r234122:
     It seems that libdisk(3) incorrectly sets d_secperunit value.
     Automatically fix it like GEOM_PART_BSD does.
   
     PR:		bin/165789
 
 Modified:
   stable/8/sbin/bsdlabel/bsdlabel.c
 Directory Properties:
   stable/8/sbin/bsdlabel/   (props changed)
 
 Modified: stable/8/sbin/bsdlabel/bsdlabel.c
 ==============================================================================
 --- stable/8/sbin/bsdlabel/bsdlabel.c	Wed Apr 18 05:16:02 2012	(r234410)
 +++ stable/8/sbin/bsdlabel/bsdlabel.c	Wed Apr 18 05:16:20 2012	(r234411)
 @@ -1187,7 +1187,8 @@ checklabel(struct disklabel *lp)
  			lp->d_interleave = vl->d_interleave;
  		if (lp->d_secpercyl == 0)
  			lp->d_secpercyl = vl->d_secpercyl;
 -		if (lp->d_secperunit == 0)
 +		if (lp->d_secperunit == 0 ||
 +		    lp->d_secperunit > vl->d_secperunit)
  			lp->d_secperunit = vl->d_secperunit;
  		if (lp->d_bbsize == 0)
  			lp->d_bbsize = vl->d_bbsize;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"