From owner-freebsd-current@FreeBSD.ORG Tue Apr 29 16:20:28 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2637D1065676 for ; Tue, 29 Apr 2008 16:20:28 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.230]) by mx1.freebsd.org (Postfix) with ESMTP id EF4C38FC1C for ; Tue, 29 Apr 2008 16:20:27 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so39612rvf.43 for ; Tue, 29 Apr 2008 09:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; bh=gNEtib/HPOEWik4XstfTyBziAa8EmcV56qDwHS5FQEE=; b=dxKQawanrAj4lml++oh6PNsLaLw80weC6TCF9OhQGiJMHaNcfh5ks78kCJBKpk+UbmZG7xsi3/AuE/9bpWa6aC++xgY12NZpZ93l8ZW3zXkjoUbjJkrK6GdM/a93s6iAMO0mFEziidNAIRE9epJI2S0EPdHESesnuAlJ45IPDs8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=LAcwhmPjxYfX5FvvTkli4rHE2F65evtuB4iZ3EmWAmIPiVcZB70ZziOBCtdv5SEC2UnUn32HbCSwMC/4MPFGUDQm3cbWbb0kEOjDQUjzv2ja4fT4Cuzz4TfKXHAZDtdXv5clfBvyKvnIzXs0xTTzxrlvOs3e0FcV5YyLhfYMXGg= Received: by 10.141.113.6 with SMTP id q6mr1097134rvm.36.1209486027424; Tue, 29 Apr 2008 09:20:27 -0700 (PDT) Received: by 10.141.79.7 with HTTP; Tue, 29 Apr 2008 09:20:26 -0700 (PDT) Message-ID: <7d6fde3d0804290920q7278acecn6b437ff617d3a1de@mail.gmail.com> Date: Tue, 29 Apr 2008 09:20:26 -0700 From: "Garrett Cooper" To: current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Subject: Concerns about .../src/lib/libc/gen/glob.c in 8-CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Apr 2008 16:20:28 -0000 Hi again all, Not sure who yanked up the warnings or if gcc is in a particularly bad mood but it appears that compiling this source file is now failing on 8-CURRENT for me with the following message: cc -fpic -DPIC -O3 -pipe -fno-strict-aliasing -march=prescott -I/devel/ncvs/src/lib/libc/include -I/devel/ncvs/src/lib/libc/../../include -I/devel/ncvs/src/lib/libc/i386 -D__DBINTERFACE_PRIVATE -I/devel/ncvs/src/lib/libc/../../contrib/gdtoa -I/usr/obj/devel/ncvs/src/lib/libc -I/devel/ncvs/src/lib/libc/resolv -DPOSIX_MISTAKE -I/devel/ncvs/src/lib/libc/locale -DBROKEN_DES -DPORTMAP -DDES_BUILTIN -I/devel/ncvs/src/lib/libc/rpc -DSYMBOL_VERSIONING -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /devel/ncvs/src/lib/libc/gen/glob.c -o glob.So /devel/ncvs/src/lib/libc/gen/glob.c: In function 'globexp1': /devel/ncvs/src/lib/libc/gen/glob.c:242: warning: initialization discards qualifiers from pointer target type *** Error code 1 I didn't remember what the error was but looked it up and it appears that there was some concern about casting and modify the reference that a const pointer was pointing to. I looked over the source and although I was concerned about the code in globexp2 (in particular the reassigning of const pointers and incrementing going on), I didn't see anything wrong in globexp1. I could have totally missed something non-obvious though... Thanks, -Garrett