From owner-freebsd-embedded@freebsd.org Sat Apr 2 00:06:55 2016 Return-Path: Delivered-To: freebsd-embedded@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02C1CB00B62 for ; Sat, 2 Apr 2016 00:06:55 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D363E1289 for ; Sat, 2 Apr 2016 00:06:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id CF088B00B61; Sat, 2 Apr 2016 00:06:54 +0000 (UTC) Delivered-To: embedded@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEA20B00B60 for ; Sat, 2 Apr 2016 00:06:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x233.google.com (mail-ig0-x233.google.com [IPv6:2607:f8b0:4001:c05::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 955641287; Sat, 2 Apr 2016 00:06:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-ig0-x233.google.com with SMTP id f1so6765042igr.1; Fri, 01 Apr 2016 17:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=DdoB7LoeTMQdmfqqgtsVJ7feMtMqVG1VuuDUd1L1Lmo=; b=0iLKEe2XBH6A2eIN63J1wCXXy9esCm6Np99O1tUwjxya6CvKEYjxyOfIJGvqpEPIPH NN9YTUDPI78s3DsaDKWvTmQydadM3EwSmxrFisD+J1fw1fWoEoauNCGYuZa0qsJtKX0o XpKWxZiwuXztymW4H1tTbHJKVt9Vom3APbsfkqoqHoDw07T8QUb8T/Hh8eomHVq1tw8a cRYYP0K5UYhBxPaANC4+8s+nRm3dDgicHPOo1T+J7o6dmAWztl6pIhjl7MNtRNtUQFPK kGFK7fiYMXTl6OfkF4GAjypRVX6EF7eIvbc+xZAcyqVBTqCWnwQVz4ei+3gBaa9Efx0Q D7og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=DdoB7LoeTMQdmfqqgtsVJ7feMtMqVG1VuuDUd1L1Lmo=; b=VkGQ47JzwRuRlkHVJnGywbcg49myMQt6iaXWpVY7H92CFcDmpM06jwDC7yb0l3HjJ4 WGpHWZYRB3BhOiuu7A6lABY9YyRVqI/jQNqE9V9pP+9CgX07ThiukKVW2wbg/kVNa/PD QcSlMoSpJjM2ZSMD17tM0BmnGjWhjjZlAh2+ZXViERmwxMMRzrj2d5Fn38uhV17nh27O 69+P2xaJOHlNr8qfSZHAlECIFlSBiZ08sm4h6llgfIuvOaWy1PpwRObC1PMwInIr1lh/ FKExCyUYBe+OZtZ9Z01iCj5Wxdwa9EjFwjGo7fCVMiL/MpBKHbwqLbkDPACbPENEXQMq As2g== X-Gm-Message-State: AD7BkJKOg1/ZSfUfO/psJFqy8l7Rr/JTrYPXdx+fSmLBEAQ3fsdyAmz7yVw4ZY33i5fJEiO8JkyRkL00e3uJ+w== MIME-Version: 1.0 X-Received: by 10.107.134.166 with SMTP id q38mr13276252ioi.165.1459555613796; Fri, 01 Apr 2016 17:06:53 -0700 (PDT) Received: by 10.36.14.19 with HTTP; Fri, 1 Apr 2016 17:06:53 -0700 (PDT) In-Reply-To: References: <20150817160423.GB3078@gmail.com> Date: Fri, 1 Apr 2016 17:06:53 -0700 Message-ID: Subject: Re: spigen(4) SPI Generic IO interface -- need comments From: Adrian Chadd To: Brian Fundakowski Feldman Cc: Warner Losh , Luiz Otavio O Souza , "freebsd-embedded@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2016 00:06:55 -0000 ok. So this just attaches to each spibus that is found, right? Can you share your example program(s)? I'd like to see how you used the mmap version. -adrian On 1 April 2016 at 14:23, Brian Fundakowski Feldman wrote: > Great! I think the last part I wanted to have was a manpage that covered > configuring the device tree (dump, edit, rebuild) because that was fairly > non-obvious to me. I have only tested it on the RPi2 myself. > > > On Fri, Apr 1, 2016, 5:12 PM Adrian Chadd wrote: >> >> hihi! >> >> ok, I'd now like to resurrect this - I'll take a look and see what's >> missing before we throw it into the tree. I'd like to use this for the >> atheros MIPS SPI stuff so i can more efficiently speak to an LCD. :P >> >> Thanks! >> >> >> -adrian >> >> >> On 22 August 2015 at 17:27, Brian Fundakowski Feldman >> wrote: >> > You know, now you're making me wonder if the edge behavior shouldn't >> > also be >> > configurable per-spigen/per-transfer. Chip select polarity seems far too >> > dangerous to expose that way. The only SPI device I have lying around so >> > far >> > is an MCP3008. >> > >> > >> > On Sat, Aug 22, 2015, 8:17 PM Warner Losh wrote: >> >> >> >> I've worked on one set of flash that had simple commands for >> >> identifying >> >> it, which were clocked at one rate (slow, to be compatible with older >> >> members of the family), and other commands that were data transfer that >> >> were >> >> clocked faster to match the data coming from internal pipelines in the >> >> part. >> >> I don't know how common this arrangement is in the wild, though. >> >> >> >> And all of this is from memory of something I worked on maybe 10 years >> >> ago >> >> now, so I'm not sure how relevant it is today. I do know NAND flash >> >> chips >> >> have similar behavior, but those don't have a SPI bus. >> >> >> >> Warner >> >> >> >> >> >> On Sat, Aug 22, 2015 at 6:09 PM, Brian Fundakowski Feldman >> >> wrote: >> >>> >> >>> That's something I want feedback on: are there scenarios where you >> >>> want >> >>> to >> >>> regularly vary the clock to a specific SPI device, as opposed to >> >>> varying >> >>> it >> >>> among several? It would be easy to add to the transfer ioctls if you >> >>> have >> >>> a >> >>> use case (for example, manual chip select control with more devices >> >>> than >> >>> chip select pins in your low-level SPI implementation.) Certainly >> >>> from a >> >>> runtime cost perspective it would be no burden. >> >>> >> >>> Thanks for taking a look! >> >>> -- >> >>> green >> >>> >> >>> On Sat, Aug 22, 2015, 5:55 PM Adrian Chadd >> >>> wrote: >> >>> >> >>> > Hi! >> >>> > >> >>> > This looks cool! Is there any reason why the clock isn't per >> >>> > transaction? >> >>> > >> >>> > >> >>> > -a >> >>> > >> >>> > >> >>> > On 22 August 2015 at 11:23, Brian Fundakowski Feldman >> >>> > wrote: >> >>> > > I've added a couple more features: >> >>> > > * clock adjustment via ioctl, independent per spigenN device >> >>> > > * mmap(2) support for very low latency >> >>> > > >> >>> > > On Tue, Aug 18, 2015 at 6:47 PM, Brian Fundakowski Feldman < >> >>> > > brianfundakowskifeldman@gmail.com> wrote: >> >>> > > >> >>> > >> On Mon, Aug 17, 2015 at 12:04 PM Tom Jones wrote: >> >>> > >> >> >>> > >>> On Mon, Aug 17, 2015 at 10:00:26AM -0400, Brian Fundakowski >> >>> > >>> Feldman >> >>> > wrote: >> >>> > >>> > I'm woefully out-of-practice with my kernel hackery (but still >> >>> > >>> > pretty >> >>> > >>> > proficient in jiggery-pokery) so I would like to get comments >> >>> > >>> > on >> >>> > >>> > a >> >>> > >>> little >> >>> > >>> > driver I just made for interfacing arbitrarily in userland >> >>> > >>> > with >> >>> > >>> > SPI >> >>> > >>> > components. The only thing I'm exposing is a /dev/spigenN >> >>> > >>> > node >> >>> > >>> > with >> >>> > a >> >>> > >>> > single transfer ioctl and I put together a test circuit and >> >>> > >>> > program >> >>> > >>> with an >> >>> > >>> > MCP3008 10-bit ADC IC to validate that it basically works, >> >>> > >>> > other >> >>> > >>> > than >> >>> > >>> the >> >>> > >>> > limitation that the transfers must be octet-multiply-sized, >> >>> > >>> > but I >> >>> > >>> haven't >> >>> > >>> > looked at the SoC's (I'm using a Raspberry Pi 2) data sheet to >> >>> > >>> > tell >> >>> > >>> whether >> >>> > >>> > that's just a limit on the spibus(4) interface or the Broadcom >> >>> > >>> > SPI >> >>> > >>> driver >> >>> > >>> > or the Broadcom SoC itself. >> >>> > >>> > >> >>> > >>> > I hit one snag in development where I simply called the ioctl >> >>> > >>> > wrong >> >>> > and >> >>> > >>> > found copyin(9) to page fault HARD if given a bogus user >> >>> > >>> > address >> >>> > >>> > to >> >>> > copy >> >>> > >>> > from, and panic the kernel. I can post up the test program if >> >>> > >>> > anyone >> >>> > >>> wants >> >>> > >>> > but it's very trivial: I just align the start bit and the >> >>> > >>> > command >> >>> > data >> >>> > >>> into >> >>> > >>> > the least significant bits of the first octet, shift it up two >> >>> > >>> positions so >> >>> > >>> > the NULs get clocked out as part of the command field, and >> >>> > >>> > provide >> >>> > two >> >>> > >>> > octets for the data field to retrieve back the 10-bit digital >> >>> > >>> > value. >> >>> > >>> >> >>> > >>> Oh, cool. >> >>> > >>> >> >>> > >>> I did the same earlier this year, have you seen[1]?. >> >>> > >>> >> >>> > >>> The FreeBSD i2c api is the same/very similar the linux >> >>> > >>> one[2][3]. >> >>> > >>> Have >> >>> > you >> >>> > >>> considered adding some of the ioctls[3] or the data structures >> >>> > >>> to >> >>> > >>> make >> >>> > it >> >>> > >>> easier to port code? >> >>> > >>> >> >>> > >>> [1]: >> >>> > >>> >> >>> > >> >>> > >> >>> > https://lists.freebsd.org/pipermail/freebsd-embedded/2015-April/002466.html >> >>> > >>> [2]: https://www.kernel.org/doc/Documentation/i2c/dev-interface >> >>> > >>> [3]: >> >>> > >>> >> >>> > >> >>> > >> >>> > https://www.freebsd.org/cgi/man.cgi?query=iic&apropos=0&sektion=0&manpath=FreeBSD+10.2-RELEASE&arch=default&format=html >> >>> > >>> [4]: https://www.kernel.org/doc/Documentation/spi/spidev >> >>> > >> >> >>> > >> >> >>> > >> I've iterated a bit on this to try to make some more sensible >> >>> > >> API, >> >>> > >> behaving reasonably about being able to set the SPI clock speed. >> >>> > >> I'm >> >>> > going >> >>> > >> to implement an mmap handler so I can have my low-latency >> >>> > >> operation >> >>> > mode, >> >>> > >> as well. I don't like the Linux APIs one bit because it's just >> >>> > >> not >> >>> > safe to >> >>> > >> allow all those configuration changes on a per-transfer basis... >> >>> > >> >> >>> > >> Moving this to -embedded because it's more apt than -hackers. >> >>> > >> >> >>> > > >> >>> > > _______________________________________________ >> >>> > > freebsd-embedded@freebsd.org mailing list >> >>> > > https://lists.freebsd.org/mailman/listinfo/freebsd-embedded >> >>> > > To unsubscribe, send any mail to " >> >>> > freebsd-embedded-unsubscribe@freebsd.org" >> >>> > >> >>> _______________________________________________ >> >>> freebsd-embedded@freebsd.org mailing list >> >>> https://lists.freebsd.org/mailman/listinfo/freebsd-embedded >> >>> To unsubscribe, send any mail to >> >>> "freebsd-embedded-unsubscribe@freebsd.org" >> >> >> >> >> >