From owner-freebsd-current@FreeBSD.ORG Sat Jun 13 15:31:10 2015 Return-Path: Delivered-To: current@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 83DBFC34; Sat, 13 Jun 2015 15:31:10 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3C8EA2E6; Sat, 13 Jun 2015 15:31:10 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1Z3nOf-000F77-0J; Sat, 13 Jun 2015 18:31:01 +0300 Date: Sat, 13 Jun 2015 18:31:00 +0300 From: Slawa Olhovchenkov To: Glen Barber Cc: Oliver Pinter , current@freebsd.org, FreeBSD Release Engineering Team Subject: Re: broken release generation when Message-ID: <20150613153100.GE58397@zxy.spb.ru> References: <20150613143546.GA2333@hub.FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150613143546.GA2333@hub.FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jun 2015 15:31:10 -0000 On Sat, Jun 13, 2015 at 02:35:46PM +0000, Glen Barber wrote: > [re@ CC'd] > > On Sat, Jun 13, 2015 at 02:34:37PM +0200, Oliver Pinter wrote: > > Hi all! > > > > We got build error with custom BRANCH= in newvers.sh. The release > > process unable to generate the ISO files but they not stopped with > > error, just ignore them, and continue with memstick images. > > > > > > cp /jenkins/workspace/HardenedBSD-stable-master-amd64/release/rc.local > > bootonly/etc > > sh /jenkins/workspace/HardenedBSD-stable-master-amd64/release/amd64/mkisoimages.sh > > -b 11_0_CURRENT_HARDENEDBSD_amd64_BO bootonly.iso bootonly > > 100+0 records in > > 100+0 records out > > 409600 bytes transferred in 0.007822 secs (52361998 bytes/sec) > > newfs_msdos: cannot get number of sectors per track: Operation not supported > > newfs_msdos: cannot get number of heads: Operation not supported > > newfs_msdos: trim 44 sectors to adjust to a multiple of 63 > > /dev/md0: 717 sectors in 717 FAT12 clusters (512 bytes/cluster) > > BytesPerSec=512 SecPerClust=1 ResSectors=1 FATs=2 RootDirEnts=512 > > Sectors=756 Media=0xf8 FATsecs=3 SecPerTrack=63 Heads=1 HiddenSecs=0 > > makefs: error: The Disk Label must be at most 32 characters long > > usage: makefs [-t fs-type] [-o fs-options] [-d debug-mask] [-B endian] > > [-S sector-size] [-M minimum-size] [-m maximum-size] [-s image-size] > > [-b free-blocks] [-f free-files] [-F mtree-specfile] [-xZ] > > [-N userdb-dir] image-file directory | manifest [extra-directory ...] > > > > I think at this point either: > > 1) VOLUME_LABEL should be removed; or > 2) VOLUME_LABEL should be only set if 'uname -s' returns 'FreeBSD'. > > There have been multiple reports of issues with this, and the workaround > for edge cases is getting far too ugly at this point, so I prefer option > (1). makefs must truncate label and don't return error.