From owner-dev-commits-src-all@freebsd.org  Mon Apr 26 16:42:19 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 726DD5E73E8;
 Mon, 26 Apr 2021 16:42:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FTVzv2v4vz3r0G;
 Mon, 26 Apr 2021 16:42:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx
 [66.234.199.215])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id CCA1822309;
 Mon, 26 Apr 2021 16:42:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in
 atomic_dec_and_lock_irqsave()
To: Shawn Webb <shawn.webb@hardenedbsd.org>, Neel Chauhan <nc@FreeBSD.org>
Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
 dev-commits-src-branches@FreeBSD.org
References: <202104261545.13QFjAYB012989@gitrepo.freebsd.org>
 <20210426160242.7nddbshrccusdb5j@mutt-hbsd>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <67e6aa7a-3c1d-1055-d468-b6a366382f04@FreeBSD.org>
Date: Mon, 26 Apr 2021 09:42:18 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210426160242.7nddbshrccusdb5j@mutt-hbsd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Apr 2021 16:42:19 -0000

On 4/26/21 9:02 AM, Shawn Webb wrote:
> On Mon, Apr 26, 2021 at 03:45:10PM +0000, Neel Chauhan wrote:
>> The branch stable/13 has been updated by nc (ports committer):
>>
>> URL: https://cgit.FreeBSD.org/src/commit/?id=9db8b85a942dd5e73c0c17198835097a30dc1f7c
>>
>> commit 9db8b85a942dd5e73c0c17198835097a30dc1f7c
>> Author:     Neel Chauhan <nc@FreeBSD.org>
>> AuthorDate: 2021-04-26 15:25:33 +0000
>> Commit:     Neel Chauhan <nc@FreeBSD.org>
>> CommitDate: 2021-04-26 15:45:05 +0000
>>
>>      linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave()
>>      
>>      (cherry picked from commit e657f3de6dc29147b5373d2cc2cc47e580931e30)
> 
> Hey Neel,
> 
> Don't commits usually spend some soak time in main before being
> cherry-picked to stable branches? I'm curious why the lack of soak
> time here.

I agree.  20 minutes is far too short.  The normal minimum is 3 days.
You already have feedback on the commits to main that you should
probably adjust before merging (specifically Mateusz's quite salient point).
Requiring two immediate fixups to the original commit in main is also
indicative that the change in question isn't really ready yet.

-- 
John Baldwin