From owner-svn-src-head@FreeBSD.ORG  Mon Nov  9 18:22:59 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28])
	by hub.freebsd.org (Postfix) with ESMTP id EB9821065670;
	Mon,  9 Nov 2009 18:22:56 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: John Baldwin <jhb@freebsd.org>
Date: Mon, 9 Nov 2009 13:22:38 -0500
User-Agent: KMail/1.6.2
References: <200911062032.nA6KWRXb027876@svn.freebsd.org>
	<200911061647.00983.jhb@freebsd.org>
In-Reply-To: <200911061647.00983.jhb@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200911091322.40212.jkim@FreeBSD.org>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r199002 - in head/sys: dev/fb dev/pci isa
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2009 18:22:59 -0000

On Friday 06 November 2009 04:47 pm, John Baldwin wrote:
> On Friday 06 November 2009 3:32:26 pm Jung-uk Kim wrote:
> > Author: jkim
> > Date: Fri Nov  6 20:32:26 2009
> > New Revision: 199002
> > URL: http://svn.freebsd.org/changeset/base/199002
> >
> > Log:
> >   Remove duplicate suspend/resume code from vga_pci.c and let
> > vga(4)
>
> register
>
> >   itself to an associated PCI device if it exists.  It is little
> > bit hackish but it should fix build without frame buffer driver
> > since r198964. Fix some style(9) nits in vga_isa.c while we are
> > here.
>
> Hmm, did you consider having vga_isa use an identify routine to
> attach itself as a child of vgapci0? The hack of knowing the first
> thing in the softc is a pointer is really gross and I'd rather avoid
> it.  Just creating a child of vgapci0 will automatically cause
> suspend and resume to work w/o vgapci having to have any special
> knowledge about vga_isa. 

In fact, I did consider it.  However, lack of my new bus foo prevented 
me from doing the right thing AND fixing the build breakage at the 
same.  I'll try little harder today.

BTW, syscons <-> fb <-> vga <-> vgapci <-> etc. relationship is 
amazingly confusing. :-(

Jung-uk Kim